Support all glob path patterns

[cycraig]

Description

Only * and ** work when used in a path trigger. It would be nice to use curly braces too.

Curly brace patterns are supported by doublestar (the library used for */** in this repo), and actually work currently, but only if the path includes * too.

Example

steps:
  - label: "Triggering pipelines with glob paths"
    plugins:
      - monebag/monorepo-diff#v2.5.9:
          diff: "git diff --name-only HEAD~1"
          watch:
            - path:
                - "rust/**/*.{rs,toml,lock}" # works
                - "rust/{foo,bar}/*.{rs,sql}" # works
                - "scripts/{git-diff,install-rust}.sh" # fails, no trigger
              config:
                command: "cargo check"

Suggestion

I believe this is the relevant code? Maybe it's sufficient to check for pairs of brackets too?

This is probably a breaking change, since existing path triggers containing brackets {}/[] might behave differently (if those paths don't contain *).

https://github.com/monebag/monorepo-diff-buildkite-plugin/blob/3f65d099261bf9680da137cc4cabc363bcabcb8d/pipeline.go#L120-L125

[adikari]

I will have a look into this at some point. For now is it enough to add 2 entries for the one that is not working?

 - path:
                - "rust/**/*.{rs,toml,lock}" # works
                - "rust/{foo,bar}/*.{rs,sql}" # works
                - "scripts/install-rust.sh" 
                - "scripts/git-diff.sh" 

[cycraig]

For now is it enough to add 2 entries for the one that is not working?

Absolutely. ^^

I think only less common glob patterns like exclusions (e.g. [!asdf]) would not have an easy workaround, but those aren't very useful for path matching here anyway.

No rush on this, it was just unexpected that glob patterns only work if * is included too. Thanks!