Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation of target statement when voiding #327

Open
dnjohnson opened this issue May 16, 2013 · 8 comments
Open

Remove validation of target statement when voiding #327

dnjohnson opened this issue May 16, 2013 · 8 comments

Comments

@dnjohnson
Copy link
Contributor

The following line should be removed from the voiding requirements to allow for distributed systems:

"Upon receiving a Statement that voids another, the LRS SHOULD return a descriptive error if the target Statement cannot be found."

@garemoko
Copy link
Contributor

+1

@andyjohnson
Copy link
Contributor

Looks like this has to be a 1.1, though, as it actually changes meaning. Unless we have another spot in the document that is completely opposite of this point (and not just hinting at systems being distributed). I think we will see our fair share of these types of things that we all want, but bump the version to 1.1

@andyjohnson andyjohnson added patch and removed minor labels Oct 1, 2014
@andyjohnson
Copy link
Contributor

This is just a best practice, thus can be a patch issue.

@andyjohnson
Copy link
Contributor

We are okay removing this language as this is not actually a best practice and no enforcement is done by the LRS for SHOULD. Make this a PR.

andyjohnson added a commit to andyjohnson/xAPI-Spec that referenced this issue Oct 23, 2014
@garemoko
Copy link
Contributor

Since existing LRS might have already implemented this error, do we need to add something for 1.1 to say that the LRS MUST NOT error if the target Statement cannot be found, and MUST retain the voided statement in case it receives the target statement in future?

If it's not erroring, the client will assume the voiding was successful.

@andyjohnson
Copy link
Contributor

The interesting thing now is that the spec makes no determination on what an LRS SHOULD/MUST/MAY do when the target Statement cannot be found. The next version of the spec should address in details what we expect as voiding behavior. I think this deserves more consideration as you suggest @garemoko , so the issue will remain open as a marker for that LRS section as it is written.

@garemoko
Copy link
Contributor

garemoko commented Nov 4, 2014

@andyjohnson do you have a link to the forum discussion you mentioned in your email?

The latest discussion is on your PR here: #515 is that what you meant?

@andyjohnson
Copy link
Contributor

Ha! Yes I did! I thought it was a lost conversation, but it was just
another issue :)

On Tue, Nov 4, 2014 at 6:02 PM, Andrew Downes [email protected]
wrote:

@andyjohnson https://github.com/andyjohnson do you have a link to the
forum discussion you mentioned in your email?

The latest discussion is on your PR here: #515
#515 is that what you meant?


Reply to this email directly or view it on GitHub
#327 (comment).

Andy Johnson
ADL Technical Team
608-318-0049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants