don't raise exception for primary group failure

Author: adorton-adobe

tests/test_sign_engine.py

@@ -263,18 +263,18 @@ def test_resolve_primary_group_and_group_admin_state_umg_true(example_engine, mo
     assert 'group2' in groups_to_update
     assert groups_to_update['group2'].isPrimaryGroup is True
 
-def test_resolve_primary_group_and_group_admin_state_no_primary_group(example_engine, mock_data_for_update):
-    example_engine.resolve_primary_group = MagicMock(return_value=None)
-    with pytest.raises(AssertionException, match="Can't identify a primary group for user '[email protected]'"):
-        example_engine.resolvePrimaryGroupAndGroupAdminState(
-            is_umg=True,
-            groups_to_update=mock_data_for_update['groups_to_update'],
-            assigned_groups=mock_data_for_update['assigned_groups'],
-            desired_groups=mock_data_for_update['desired_groups'],
-            admin_groups=mock_data_for_update['admin_groups'],
-            directory_user=mock_data_for_update['directory_user'],
-            sign_user=mock_data_for_update['sign_user']
-        )
+# def test_resolve_primary_group_and_group_admin_state_no_primary_group(example_engine, mock_data_for_update):
+#     example_engine.resolve_primary_group = MagicMock(return_value=None)
+#     with pytest.raises(AssertionException, match="Can't identify a primary group for user '[email protected]'"):
+#         example_engine.resolvePrimaryGroupAndGroupAdminState(
+#             is_umg=True,
+#             groups_to_update=mock_data_for_update['groups_to_update'],
+#             assigned_groups=mock_data_for_update['assigned_groups'],
+#             desired_groups=mock_data_for_update['desired_groups'],
+#             admin_groups=mock_data_for_update['admin_groups'],
+#             directory_user=mock_data_for_update['directory_user'],
+#             sign_user=mock_data_for_update['sign_user']
+#         )
 
 def test_resolve_primary_group_and_group_admin_state_update_group_admin(example_engine, mock_data_for_update):
     groups_to_update = example_engine.resolvePrimaryGroupAndGroupAdminState(

user_sync/engine/sign.py

@@ -345,7 +345,8 @@ def resolvePrimaryGroupAndGroupAdminState(self, is_umg, groups_to_update, assign
                 current_pg = None
 
             if desired_pg is None:
-                raise AssertionException(f"Can't identify a primary group for user '{sign_user.email}'")
+                self.logger.error(f"Can't identify a primary group for user '{sign_user.email}'")
+                return
 
             if current_pg is None or desired_pg.lower() != current_pg:
                 if desired_pg.lower() in groups_to_update.keys():
@@ -577,7 +578,8 @@ def insert_new_users(self, org_name: str, sign_connector: SignConnector, directo
             if is_umg:
                 primary_group = self.resolve_primary_group(groups_to_assign.keys())
                 if primary_group is None:
-                    raise AssertionException(f"Can't identify a primary group for user '{new_user.email}'")
+                    self.logger.error(f"Can't identify a primary group for user '{new_user.email}'")
+                    return
                 self.logger.debug(f"Primary group of '{new_user.email}' is '{primary_group}'")
                 groups_to_assign[primary_group.lower()].isPrimaryGroup = True
             else: