fix: remove inert if user cycles through whole list/dnd multiple times via keyboard dnd #8581
+6
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the root cause is because in a virtualizer node reuse/reorder case triggered by the mutation observer, we were removing the node from the hidden nodes list prematurely even though it was going to be readded immediately after, causing the ref count to erroneously increment by 1 again via acceptNode's check
from testing
✅ Pull Request Checklist:
📝 Test Instructions:
Go to virtualized tree DnD/tableview dnd/ any virtualized DnD experience and test keyboard drag and drop. In particular, try starting a keyboard drag session, holding ArrowDown to cycle through the list multiple times, then canceling your drop. You should still be able to navigate to each row after that
🧢 Your Project:
RSP