feat(slack/onboard-llmo): acknowledge and process asynchronously

Author: cwjwisse

src/support/slack/actions/onboard-llmo-modal.js

@@ -602,7 +602,7 @@ export async function onboardSite(input, lambdaCtx, slackCtx) {
       await sqs.sendMessage(configuration.getQueues().audits, sqsTriggerMesasage);
 
       const message = `:white_check_mark: *LLMO onboarding completed successfully!*
-        
+
 :link: *Site:* ${baseURL}
 :identification_card: *Site ID:* ${siteId}
 :file_folder: *Data Folder:* ${dataFolder}
@@ -615,10 +615,14 @@ The LLMO Customer Analysis handler has been triggered. It will take a few minute
     } catch (error) {
       log.error(`Error saving LLMO config for site ${siteId}: ${error.message}`);
       await say(`:x: Failed to save LLMO configuration: ${error.message}`);
+      // Re-throw the error so it can be caught by the modal handler
+      throw new Error(`Failed to save LLMO configuration: ${error.message}`);
     }
   } catch (error) {
     log.error('Error in LLMO onboarding:', error);
     await postErrorMessage(say, error);
+    // Re-throw the error so it can be caught by the modal handler
+    throw error;
   }
 }
 
@@ -627,6 +631,8 @@ export function onboardLLMOModal(lambdaContext) {
   const { log } = lambdaContext;
 
   return async ({ ack, body, client }) => {
+    let hasAcknowledged = false;
+
     try {
       log.debug('Starting onboarding process...');
       const { view, user } = body;
@@ -650,6 +656,7 @@ export function onboardLLMOModal(lambdaContext) {
       const imsOrgId = values.ims_org_input.ims_org_id.value;
       const deliveryType = values.delivery_type_input?.delivery_type?.selected_option?.value;
 
+      // Validate required fields before proceeding
       if (!brandName || !imsOrgId) {
         await ack({
           response_action: 'errors',
@@ -658,6 +665,7 @@ export function onboardLLMOModal(lambdaContext) {
             ims_org_input: !imsOrgId ? 'IMS Org ID is required' : undefined,
           },
         });
+        hasAcknowledged = true;
         return;
       }
 
@@ -670,10 +678,6 @@ export function onboardLLMOModal(lambdaContext) {
         originalThreadTs,
       });
 
-      // eslint-disable-next-line max-statements-per-line
-      await new Promise((resolve) => { setTimeout(resolve, 500); });
-      await ack();
-
       // Create a slack context for the onboarding process
       // Use original channel/thread if available, otherwise fall back to DM
       const responseChannel = originalChannel || body.user.id;
@@ -692,19 +696,33 @@ export function onboardLLMOModal(lambdaContext) {
         threadTs: responseThreadTs,
       };
 
+      // Perform the onboarding operation BEFORE acknowledging the modal
+      // This way, if it fails, we can show the error in the modal
       await onboardSite({
         brandName, baseURL: brandURL, imsOrgId, deliveryType,
       }, lambdaContext, slackContext);
 
-      log.debug(`Onboard LLMO modal processed for user ${user.id}, site ${brandURL}`);
+      // Only acknowledge (and close) the modal if onboarding was successful
+      await ack();
+      hasAcknowledged = true;
+
+      log.debug(`Onboard LLMO modal processed successfully for user ${user.id}, site ${brandURL}`);
     } catch (e) {
       log.error('Error handling onboard site modal:', e);
-      await ack({
-        response_action: 'errors',
-        errors: {
-          brand_name_input: 'There was an error processing the onboarding request.',
-        },
-      });
+
+      // Only try to acknowledge with errors if we haven't already acknowledged
+      if (!hasAcknowledged) {
+        await ack({
+          response_action: 'errors',
+          errors: {
+            brand_name_input: 'There was an error processing the onboarding request. Please try again.',
+          },
+        });
+      } else {
+        // If we already acknowledged, we can't show modal errors anymore
+        // The error should have been handled by onboardSite's error handling
+        log.error('Error occurred after modal was acknowledged - error handling was done via Slack messages');
+      }
     }
   };
 }

test/support/slack/actions/onboard-llmo-modal.test.js

@@ -709,8 +709,9 @@ describe('onboard-llmo-modal', () => {
       // Make SQS sendMessage throw an error
       lambdaCtx.sqs.sendMessage.rejects(new Error('SQS service unavailable'));
 
-      // Execute the function
-      await onboardSite(input, lambdaCtx, slackCtx);
+      // Execute the function and expect it to throw
+      await expect(onboardSite(input, lambdaCtx, slackCtx))
+        .to.be.rejectedWith('Failed to save LLMO configuration: SQS service unavailable');
 
       // Verify that SQS sendMessage was called but failed
       expect(lambdaCtx.sqs.sendMessage).to.have.been.called;
@@ -1184,7 +1185,7 @@ example-com:
         originalChannel: 'C1234567890',
         originalThreadTs: '1234567890.123456',
       });
-      expect(lambdaCtx.log.debug).to.have.been.calledWith('Onboard LLMO modal processed for user U1234567890, site https://example.com');
+      expect(lambdaCtx.log.debug).to.have.been.calledWith('Onboard LLMO modal processed successfully for user U1234567890, site https://example.com');
       expect(mockAck).to.have.been.calledOnce;
     });
 
@@ -1228,7 +1229,7 @@ example-com:
       expect(mockAck).to.have.been.calledWith({
         response_action: 'errors',
         errors: {
-          brand_name_input: 'There was an error processing the onboarding request.',
+          brand_name_input: 'There was an error processing the onboarding request. Please try again.',
         },
       });
     });