Add validation for platform strings to exclude_parser.py (#5651)

* Add validation for platform strings to exclude_parser.py

* Exit with code 1 on logging of error. Only parse files in exclude_path

* Remove comment that does not apply to current code

* Simplify validation of exclusion format

Author: jiekang

scripts/disabled_tests/exclude_parser.py

@@ -10,10 +10,21 @@
 from common.models import Scheme, JdkInfo
 from common.utils import to_shallow_dict, DEFAULT_TARGET
 
+class ErrorTrackingHandler(logging.Handler):
+    def __init__(self):
+        super().__init__()
+        self.error_logged = False
+
+    def emit(self, record):
+        if record.levelno >= logging.ERROR:
+            self.error_logged = True
+
 logging.basicConfig(
     format="%(levelname)s - %(message)s"
 )
 LOG = logging.getLogger()
+ERROR_TRACKER = ErrorTrackingHandler()
+LOG.addHandler(ERROR_TRACKER)
 
 OS_EXCEPTIONS = {
     "macosx": "mac",
@@ -26,7 +37,6 @@
     "x86": "x86-32",
 }
 
-
 class ExclusionFileProcessingException(Exception):
     pass
 
@@ -112,7 +122,7 @@ class TestExclusionSplitLine(TestExclusionRawLine):
 
     @classmethod
     def from_raw_line(cls, test_excl: TestExclusionRawLine):
-        split_line = test_excl.raw_line.split(maxsplit=2)
+        split_line = test_excl.raw_line.split()
         if len(split_line) != 3:
             raise TestExclusionProcessingException(
                 f'Not exactly 3 elements when splitting {test_excl.raw_line}', test_excl)
@@ -185,7 +195,6 @@ def transform_platform(os_arch_platform: str) -> str:
 
     return f"{arch_name}_{os_name}"
 
-
 def resolve_platforms(split: TestExclusionSplitLine) -> List[str]:
     revolved_platforms = []
     list_of_unresolved_platform_names = [s.strip() for s in split.raw_platform.split(",") if s.strip()]
@@ -250,11 +259,10 @@ def main():
     if args.verbose:
         LOG.setLevel(logging.DEBUG)
 
-    # if the dir containing the exclude ProblemList*.txt is not passed, the attempt to use openjdk/excludes/ dir instead
     if args.exclude_dir:
         LOG.debug("Taking file list from directory")
-        exclude_files = [os.path.join(args.exclude_dir, file_name)
-                         for file_name in os.listdir(args.exclude_dir)]
+        exclude_files = [os.path.join(args.exclude_dir, f) for f in os.listdir(args.exclude_dir) if os.path.isfile(os.path.join(args.exclude_dir, f))]
+        LOG.debug(exclude_files)
     else:
         LOG.debug("Taking file list from stdin")
         exclude_files = [line.rstrip() for line in sys.stdin.readlines()]  # remove the \n from each lines
@@ -283,7 +291,9 @@ def main():
             fp=fp,
             indent=2,
         )
-
+    if ERROR_TRACKER.error_logged:
+        LOG.debug(f"Error found. Exiting with code 1")
+        sys.exit(1)
 
 if __name__ == '__main__':
     main()