Skip to content

Commit b5eb0bf

Browse files
Copilotdata-douser
andcommitted
Fix incorrect codeql test extract references and PR template path
Co-authored-by: data-douser <[email protected]>
1 parent 1b29566 commit b5eb0bf

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

.github/PULL_REQUEST_TEMPLATE/copilot-template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## Agent Information
44

55
**Generated by**: `@copilot` using the [agent-name] agent
6-
**Agent Definition**: [../.github/agents/agent-name.md](../.github/agents/agent-name.md)
6+
**Agent Definition**: [agent-name.md](../agents/agent-name.md)
77

88
## Changes Summary
99

.github/instructions/javascript_cap_ql.instructions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ This file contains instructions for working with CodeQL query (`.ql`) and librar
1616
- ALWAYS follow test-driven development (TDD) practices using CodeQL test commands.
1717
- ALWAYS run `codeql query format --in-place <file>` before committing changes to QL files.
1818
- ALWAYS use `codeql test run` to validate query changes before committing.
19-
- ALWAYS use `codeql test extract` to create test databases for AST exploration.
2019
- ALWAYS validate query behavior with both positive (should alert) and negative (should not alert) test cases.
2120
- NEVER make assumptions about CAP framework behavior - validate with real code and CodeQL CLI.
2221
- NEVER commit query changes without passing tests.
@@ -44,7 +43,7 @@ This file contains instructions for working with CodeQL query (`.ql`) and librar
4443
- ALWAYS create comprehensive test cases in `javascript/frameworks/cap/test/`.
4544
- ALWAYS include both JavaScript and CDS files in tests when relevant.
4645
- ALWAYS verify expected results before accepting with `codeql test accept`.
47-
- ALWAYS use `codeql test extract` + PrintAST query to understand unfamiliar patterns.
46+
- ALWAYS use `codeql test run` with a PrintAST query to understand unfamiliar patterns.
4847

4948
## PREFERENCES
5049

.github/instructions/javascript_ui5_ql.instructions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ This file contains instructions for working with CodeQL query (`.ql`) and librar
1616
- ALWAYS follow test-driven development (TDD) practices using CodeQL test commands.
1717
- ALWAYS run `codeql query format --in-place <file>` before committing changes to QL files.
1818
- ALWAYS use `codeql test run` to validate query changes before committing.
19-
- ALWAYS use `codeql test extract` to create test databases for AST exploration.
2019
- ALWAYS validate query behavior with both positive (should alert) and negative (should not alert) test cases.
2120
- NEVER make assumptions about UI5 framework behavior - validate with real code and CodeQL CLI.
2221
- NEVER commit query changes without passing tests.
@@ -49,7 +48,7 @@ This file contains instructions for working with CodeQL query (`.ql`) and librar
4948
- ALWAYS create comprehensive test cases in `javascript/frameworks/ui5/test/`.
5049
- ALWAYS include both JavaScript controllers and XML views in tests.
5150
- ALWAYS verify expected results before accepting with `codeql test accept`.
52-
- ALWAYS use `codeql test extract` + PrintAST query to understand unfamiliar patterns.
51+
- ALWAYS use `codeql test run` with a PrintAST query to understand unfamiliar patterns.
5352
- ALWAYS test binding expression parsing separately.
5453

5554
## PREFERENCES

.github/instructions/javascript_xsjs_ql.instructions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ This file contains instructions for working with CodeQL query (`.ql`) and librar
1616
- ALWAYS follow test-driven development (TDD) practices using CodeQL test commands.
1717
- ALWAYS run `codeql query format --in-place <file>` before committing changes to QL files.
1818
- ALWAYS use `codeql test run` to validate query changes before committing.
19-
- ALWAYS use `codeql test extract` to create test databases for AST exploration.
2019
- ALWAYS validate query behavior with both positive (should alert) and negative (should not alert) test cases.
2120
- NEVER make assumptions about XSJS framework behavior - validate with real code and CodeQL CLI.
2221
- NEVER commit query changes without passing tests.
@@ -47,7 +46,7 @@ This file contains instructions for working with CodeQL query (`.ql`) and librar
4746
- ALWAYS create comprehensive test cases in `javascript/frameworks/xsjs/test/`.
4847
- ALWAYS include realistic XSJS code patterns in tests.
4948
- ALWAYS verify expected results before accepting with `codeql test accept`.
50-
- ALWAYS use `codeql test extract` + PrintAST query to understand unfamiliar patterns.
49+
- ALWAYS use `codeql test run` with a PrintAST query to understand unfamiliar patterns.
5150

5251
## PREFERENCES
5352

0 commit comments

Comments
 (0)