-
-
Notifications
You must be signed in to change notification settings - Fork 86
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Got this reply in an /r/react thread:
Nice. I kept looking and looking where you generate the different manifest.json files. But it looks like you used a combined one.
Be aware that there are slight differences in FF and Chrome supported extensions. So I had to keep separate manifest.json files for each browser.
The problem is that each of the browsers doesn't load the extension if the manifest contains invalid stuff that the other one supports ( e.g. optional permissions, or unsupported permissions )
I am on mobile now so difficult for me to diff. But you can see the subtle differences here :
https://github.com/stefanXO/Tab-Manager-Plus/blob/master/manifest.json
https://github.com/stefanXO/Tab-Manager-Plus/blob/master/manifest-firefox.json
There should be separate yarn build:firefox and yarn build:chrome scripts (instead of just having yarn build) that can copy a different source manfiest.json file to account for small variations between the two different browsers.
arobert-attraqt
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed