LLM-27035 [Codex] Add missing elicitation, LLM-27036 [Codex] Improve mcp block detection #478
NikolaiSviridovAnnotations
8 errors and 3 warnings
|
test
Process completed with exit code 1.
|
|
src/__tests__/CodexACPAgent/load-session.test.ts > CodexACPAgent - loadSession > should replay history during loadSession:
src/__tests__/CodexACPAgent/load-session.test.ts#L167
Error: Snapshot `CodexACPAgent - loadSession > should replay history during loadSession 1` mismatched
- Expected
+ Received
@@ -161,10 +161,13 @@
"status": "completed",
"rawInput": {
"server": "github",
"tool": "search",
"arguments": {}
+ },
+ "_meta": {
+ "is_mcp_tool_call": true
}
}
}
]
}
❯ src/__tests__/CodexACPAgent/load-session.test.ts:167:9
|
|
src/__tests__/CodexACPAgent/elicitation-events.test.ts > Elicitation Events > MCP tool call approval elicitation > should show only Allow and Decline when no persist options:
src/__tests__/CodexACPAgent/elicitation-events.test.ts#L240
Error: Snapshot `Elicitation Events > MCP tool call approval elicitation > should show only Allow and Decline when no persist options 1` mismatched
- Expected
+ Received
@@ -3,11 +3,11 @@
"args": [
{
"sessionId": "test-session-id",
"toolCall": {
"toolCallId": "elicitation-tool-server",
- "kind": "other",
+ "kind": "execute",
"status": "pending",
"content": [
{
"type": "content",
"content": {
❯ src/__tests__/CodexACPAgent/elicitation-events.test.ts:240:13
|
|
src/__tests__/CodexACPAgent/elicitation-events.test.ts > Elicitation Events > MCP tool call approval elicitation > should only show session option when persist is "session":
src/__tests__/CodexACPAgent/elicitation-events.test.ts#L221
Error: Snapshot `Elicitation Events > MCP tool call approval elicitation > should only show session option when persist is "session" 1` mismatched
- Expected
+ Received
@@ -3,11 +3,11 @@
"args": [
{
"sessionId": "test-session-id",
"toolCall": {
"toolCallId": "elicitation-tool-server",
- "kind": "other",
+ "kind": "execute",
"status": "pending",
"content": [
{
"type": "content",
"content": {
❯ src/__tests__/CodexACPAgent/elicitation-events.test.ts:221:13
|
|
src/__tests__/CodexACPAgent/elicitation-events.test.ts > Elicitation Events > MCP tool call approval elicitation > should show Allow/session/always/Decline options when all persist values advertised:
src/__tests__/CodexACPAgent/elicitation-events.test.ts#L145
Error: Snapshot `Elicitation Events > MCP tool call approval elicitation > should show Allow/session/always/Decline options when all persist values advertised 1` mismatched
- Expected
+ Received
@@ -3,11 +3,11 @@
"args": [
{
"sessionId": "test-session-id",
"toolCall": {
"toolCallId": "elicitation-tool-server",
- "kind": "other",
+ "kind": "execute",
"status": "pending",
"content": [
{
"type": "content",
"content": {
❯ src/__tests__/CodexACPAgent/elicitation-events.test.ts:145:13
|
|
src/__tests__/CodexACPAgent/command-action-events.test.ts > CodexEventHandler - command action events > should preserve repeated mcp progress messages in final output:
src/__tests__/CodexACPAgent/command-action-events.test.ts#L384
Error: Snapshot `CodexEventHandler - command action events > should preserve repeated mcp progress messages in final output 1` mismatched
- Expected
+ Received
@@ -73,10 +73,13 @@
"server": "server-name",
"tool": "tool-name",
"arguments": {
"argument": "example"
}
+ },
+ "_meta": {
+ "is_mcp_tool_call": true
}
}
}
]
}
❯ src/__tests__/CodexACPAgent/command-action-events.test.ts:384:9
|
|
src/__tests__/CodexACPAgent/command-action-events.test.ts > CodexEventHandler - command action events > should include mcp progress and final logs:
src/__tests__/CodexACPAgent/command-action-events.test.ts#L316
Error: Snapshot `CodexEventHandler - command action events > should include mcp progress and final logs 1` mismatched
- Expected
+ Received
@@ -62,10 +62,13 @@
"file_path": ".ai/local.md",
"mode": "slice",
"start_line": 1,
"max_lines": 200
}
+ },
+ "_meta": {
+ "is_mcp_tool_call": true
}
}
}
]
}
❯ src/__tests__/CodexACPAgent/command-action-events.test.ts:316:9
|
|
src/__tests__/CodexACPAgent/command-action-events.test.ts > CodexEventHandler - command action events > should handle mcp tools:
src/__tests__/CodexACPAgent/command-action-events.test.ts#L258
Error: Snapshot `CodexEventHandler - command action events > should handle mcp tools 1` mismatched
- Expected
+ Received
@@ -13,10 +13,13 @@
"server": "server-name",
"tool": "tool-name",
"arguments": {
"argument": "example"
}
+ },
+ "_meta": {
+ "is_mcp_tool_call": true
}
}
}
]
}
❯ src/__tests__/CodexACPAgent/command-action-events.test.ts:258:9
|
|
typecheck
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
test
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
binaries
Expired
|
203 MB |
sha256:416fd635aa0cec2888eeb79f2c89ba8279f518f2d7e454fce3ecf7aff11cc6fa
|
|