Skip to content

bug: false warning in AggOracle #1518

@joanestebanr

Description

@joanestebanr

Bug Report

Version > 0.8.1

When aggoracle is created emit a warning even if the values is right:

[AggOracle.EVMSender.EthTxManager.Etherman]
    L1ChainID = 13473

Emit next warning: Incorrect ChainID in aggOracle provided: 13473 expected: 686868

The number that show the warning is not the right value (must be the eth_chainId of the RPC) and the expected is the rollup ChainID

  • The field AggOracle.EVMSender.EthTxManager.Etherman.L1ChainID must not be informed because by default is 0 that is autodiscover. In that case emit also a false warning:
Incorrect ChainID in aggOracle provided: 0 expected: 686868

Proposed solution

  • Remove this warning because doesn't have any sense, if we want to check this value we have to add a warning in the library zkevm_ethtx_manager (may be it's already there)
  • Encourage to don't set this value in config file because by default is auto-configured

Additional context

Reported by @tnobayashi

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions