v6 missing from releases

[IzzySoft]

module.prop suggests there is a v6 available, but the latest release (and also tag) is v5.5. Will the v6 tag be created, and the corresponding ZIP file attached? Maybe you just forgot?

[ahkehra]

will release. I nearly forgot 😅

[IzzySoft]

Thanks! Good that my updater just complained (your module is in my repo) or you might not have remembered at all 🙈 I see the tag is there now. Can you give me a ping here when the release has been created and the ZIP is attached? Then I'd trigger a rescan here.

[ahkehra]

Sure. 👍

[IzzySoft]

Looks like now that v6 is there, v6.5 is missing 🙈

[IzzySoft]

@ahkehrah v6.5 attachment is still missing. Will you add it? You've adjusted the version back in May, so since then on each update run I receive an error (404 for the ZIP). Are you still around and can fix that? Thanks in advance!

[IzzySoft]

@ahkehra now your module.prop points to a v7.0-beta which does not exist. Maybe only update that version/url when the target is available? There's still no v6.5, so the IoD Magisk repo is still stuck with v6.0. So can you make the version your module.prop suggests to use available? Thanks in advance!

[ahkehra]

Actually, I've been wanting to fix a bug for a long time, where the CPU core usage sometimes spikes and causes overheating. That's why I haven't published it yet.

[ahkehra]

I will notify you once this issue is fixed, so please be patient, apologies for any inconvenience caused by this issue.

[IzzySoft]

Thanks! And yes, I'll be patient (and ignore the update check failures a little longer). To prevent those failures with update checks, maybe always have the module.prop point to the latest existing release? Then folks like me would have no reasons to "complain" 😉

Of course you could also have an update.json for that purpose:

{
    "version": "v6",
    "versionCode": "60",
    "zipUrl": "https://github.com/realakeera/high_perf_dac/releases/download/v6/high_perf_dac-v6.zip ",
    "changelog": ""
}

would currently match. I could then point the updater here to that (and wouldn't have to construct an update.json locally based on the module.prop) – so your module.prop could be properly used for "development versions", while the update.json points to the stable one to be used by others (and fetched to repos like mine).

[ahkehra]

You're welcome! That’s a great suggestion, and I appreciate your patience. Using module.prop for development versions and an update.json for stable releases sounds like an efficient approach to streamline update checks and prevent failures. I’ll definitely consider implementing this and make things more organized for repos. Actually, I've been quite busy these days, which is why I haven't noticed or implemented this yet. I'll take care of it later Thankyou 💌.

[IzzySoft]

Thanks a lot! Please give me a ping when it's there so I can check and update the config here accordingly.

Edit: Ah, I see it's there already, let me check then…

[IzzySoft]

Yay, cool, works!

$ util/cli.py sync -i high_perf_dac
[2024/11/19 16:07:02] Config DEBUG: name = IzzyOnDroid Magisk Repo
[2024/11/19 16:07:02] Config DEBUG: base_url = https://apt.izzysoft.de/magisk/
[2024/11/19 16:07:02] Config DEBUG: max_num = 3
[2024/11/19 16:07:02] Config DEBUG: enable_log = True
[2024/11/19 16:07:02] Config DEBUG: log_dir = magisk/log
[2024/11/19 16:07:02] LocalTracks INFO: get_tracks: modules_folder = magisk/modules
[2024/11/19 16:07:02] LocalTracks INFO: get_tracks: size = 1
[2024/11/19 16:07:02] Pull DEBUG: from_track: [high_perf_dac] -> type: ONLINE_JSON
[2024/11/19 16:07:05] Pull INFO: _check_version_code: [high_perf_dac] -> already the latest version

No errors anymore 🤩

Solved then I guess and we can close this issue – unless you want to keep it as reminder for something?

[ahkehra]

Yeah don't close