-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation failed #11
Comments
Share magisk log? |
Dne 18. 10. 2023 13:52 napsal uživatel Vishal Rajput ***@***.***>:
Share magisk log?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I have the same issue, the log is below. V5 installs successfully, just not V6. I also have a question, when you say "Need Kernel Support" do you mean this needs some kernel flags you would only find in a custom kernel, or would it be supported by some stock kernels? Thank you again for your work! Can't believe this doesn't have more exposure with how crazy the audiophile community is. I'm also wondering, do you have any further insight on what this actually does? I can't find any documentation on it anywhere, especially since the original XDA thread got taken off the internet.
|
Yes Need Kernel Support buzzcut-s/kernel_msm8996@984a263 Every phone powered by a Qualcomm processor has a built-in WCD9xx Audio DAC, but it's rarely configured to be used to its full potential by OEMs. ... By enabling High-Performance Mode, the audio quality of Qualcomm-powered devices will not only receive a boost in volume but will sound more clear and crisp as well. |
Thank you for the response! Hmmm, wonder how it works internally. Maybe it increase the amplifier gain? Not sure that would necessarily improve sound quality though. Looking at the source code, the description is "enable/disable class AB config for hph". Definitely doesn't reveal much, so mysterious... It looks like high performance mode enables these parameters:
I'm also not sure this is even possible on newer phones, looking through newer phone source code I have yet to see "high_perf_mode" as an option in WCD9335+ phones. Still, Qualcomm says on their own website "High Performance Audio Playback" exists all the way up to the 9385. |
@oiakera do you know if anyone has gotten this to work with a newer SOC like the 8 Gen 1? |
Nope I don't have tester and I'm using SD870. |
Thanks again for the reply, that's very helpful. The 870 has the newest DAC Qualcomm makes, the WCD9385, too bad you don't have a way to test it. |
Hey there, i have the same issue but i'm using KSU i have a Joyeuse (miatoll) with a Qualcomm Snapdragon 720G, for what i read should have an internal WCD9385 DAC if i flash the v5.5 works ok, but with v6 the script doesn't install. I attached the log. Thanks. |
Try this |
It worked, flashed correctly. |
Nice 👍 |
Flashed correctly for me too, rightfully tells me my kernel isn't supported. Thank you! @FunkyNico does it work with your kernel? What kernel are you using? My log in case anyone wants to see it:
|
I see that you're using magisk so i don't know it has something do with, but i'm using melon kernel with KSU. I don't know for sure if it's working because i didn't see on the logs if it detects that i have qualcomm, and kernel support as you can see. Also for what i hear it sounds good, but i also have audio-jitter-remover and drc-remover. |
@FunkyNico can you see if you have any of the following folders in /sys/modules? If you do, then it's working as intended. /sys/module/high_perf_mode |
I do not have any of these folders under /sys/module/. BTW: I will install v5.5 just to check what happens. |
@FunkyNico As I feared, i think your kernel is not compatible. Thanks for checking! |
Ok i just installed back v5.5 and nothing happens, i attach the log. Then i tried installing other kernel, in this case VelvetKernel r4 for my device and then install back v6, also nothing happens, there's no folders. Greetings. |
Damn, that's really too bad. I've been trying to find any recent kernels that have looked at modifying the high performance dac parameters, but unfortunately haven't been able to find a single one for any device. Hoping to get some time, maybe over the holidays, to look at implementing these older DAC modifications on the WCD9385. |
Installation failed
The text was updated successfully, but these errors were encountered: