MIDI event editor seems essentially broken

[sylsau]

$ seq64 --version

seq64 0.96.8-10-geeab25f3 * midi_control 2020-07-30
Built Jan 22 2021 23:49:31
  C++ version 201402
  App name: seq64; type gtk; engine rtmidi
  Build OS: 'Linux 5.10.7-arch1-1 x86_64'
  Native JACK/ALSA (rtmidi)
  Event editor
  Follow progress bar
  Highlight edit pattern
  Highlight empty patterns
  JACK session
  JACK support
  Seq32 chord generator, LFO window, menu buttons, transpose
  BPM Tap button, solid piano-roll grid
  Song performance recording
  Optional pattern coloring
  Multiple main windows
  Pause support
  Save time-sig/tempo
  64-bit

Hello !

The idea of a plain MIDI event editor is very attractive and it's definitely a great addition to seq64. Unfortunately, using the midi_control version, I was still unable to make it work even slightly.
In the attached video we can see how random notes are deleted on edition and how the program crashes when I try to save the sequence:
https://user-images.githubusercontent.com/3996262/105559175-c885bd80-5d10-11eb-84ae-72b44eac4e9f.mp4

I hope this help,
Thank you for your work!

[ahlstromcj]

Man, that was a hard one to track down. The issue is that we were deleting the original note that was linked to the other note, causing, sometimes, a segfault. Never got it to crash under the debugger, but woke up early one day and the idea of what was wrong hit me. That being said, there are a number of other issues to be looked at eventually. The event editor is meant for looking for junk to remove or that is causing issues. Also, Note Ons and Note Offs are linked for drawing, which makes them tricky to edit. So I still have stuff to work out. I am going to do that in Seq66 and then backport the fixes. May take awhile. Thanks for the report!

…

-------- sylsau 15:16 Fri 22 Jan --------

``` $ seq64 --version seq64 0.96.8-10-geeab25f3 * midi_control 2020-07-30 Built Jan 22 2021 23:49:31 C++ version 201402 App name: seq64; type gtk; engine rtmidi Build OS: 'Linux 5.10.7-arch1-1 x86_64' Native JACK/ALSA (rtmidi) Event editor Follow progress bar Highlight edit pattern Highlight empty patterns JACK session JACK support Seq32 chord generator, LFO window, menu buttons, transpose BPM Tap button, solid piano-roll grid Song performance recording Optional pattern coloring Multiple main windows Pause support Save time-sig/tempo 64-bit ``` Hello ! The idea of a plain MIDI event editor is very attractive and it's definitely a great addition to seq64. Unfortunately, using the midi_control version, I was still unable to make it work even slightly. In the attached video we can see how random notes are deleted on edition and how the program crashes when I try to save the sequence: https://user-images.githubusercontent.com/3996262/105558673-65475b80-5d0f-11eb-807b-f5a6643f703f.mp4 I hope this help, Thank you for your work! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #216

-- "Any excuse will serve a tyrant." -- Aesop