From 647364cf956cc1e620de28b7499b3475918bb070 Mon Sep 17 00:00:00 2001 From: Dillon Cullinan Date: Thu, 20 Nov 2025 12:33:01 -0500 Subject: [PATCH 1/3] Test push dynamo base image Signed-off-by: Dillon Cullinan --- .../container-validation-backends.yml | 21 ++++++++++++++++--- container/build.sh | 4 ++-- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/.github/workflows/container-validation-backends.yml b/.github/workflows/container-validation-backends.yml index 646a707705..d4a2bf85c3 100644 --- a/.github/workflows/container-validation-backends.yml +++ b/.github/workflows/container-validation-backends.yml @@ -132,6 +132,8 @@ jobs: - { arch: arm64, runner: cpu-arm-r8g-4xlarge } name: vllm (${{ matrix.platform.arch }}) runs-on: ${{ matrix.platform.runner }} + env: + DYNAMO_BASE_IMAGE: dynamo-base:latest steps: - name: Output Node Name shell: bash @@ -157,7 +159,7 @@ jobs: aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }} aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - - name: Docker Tag and Push + - name: Push framework runtime image uses: ./.github/actions/docker-tag-push with: local_image: ${{ steps.build-image.outputs.image_tag }} @@ -170,6 +172,19 @@ jobs: azure_acr_hostname: ${{ secrets.AZURE_ACR_HOSTNAME }} azure_acr_user: ${{ secrets.AZURE_ACR_USER }} azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }} + - name: Push dynamo base image + uses: ./.github/actions/docker-tag-push + # if: ${{ github.ref_name == 'main' }} + with: + local_image: ${{ env.DYNAMO_BASE_IMAGE }} + push_tag: ai-dynamo/dynamo:${{ github.ref_name }}-dynamo-${{ matrix.platform.arch }} + aws_push: 'true' + azure_push: 'false' + aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }} + aws_default_region: ${{ secrets.AWS_DEFAULT_REGION }} + azure_acr_hostname: ${{ secrets.AZURE_ACR_HOSTNAME }} + azure_acr_user: ${{ secrets.AZURE_ACR_USER }} + azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }} - name: Run unit tests if: ${{ matrix.platform.arch != 'arm64' }} @@ -224,7 +239,7 @@ jobs: aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - - name: Docker Tag and Push + - name: Push framework runtime image uses: ./.github/actions/docker-tag-push with: local_image: ${{ steps.build-image.outputs.image_tag }} @@ -291,7 +306,7 @@ jobs: aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - - name: Docker Tag and Push + - name: Push framework runtime image uses: ./.github/actions/docker-tag-push with: local_image: ${{ steps.build-image.outputs.image_tag }} diff --git a/container/build.sh b/container/build.sh index 2bc2327cc0..a97f5387a6 100755 --- a/container/build.sh +++ b/container/build.sh @@ -842,8 +842,8 @@ fi if [[ -z "${DEV_IMAGE_INPUT:-}" ]]; then # Follow 2-step build process for all frameworks if [[ $FRAMEWORK != "NONE" ]]; then - # Define base image tag before using it - DYNAMO_BASE_IMAGE="dynamo-base:${VERSION}" + # Define base image tag before using it, or use predefined image name + DYNAMO_BASE_IMAGE=${DYNAMO_BASE_IMAGE:-dynamo-base:$VERSION} # Start base image build echo "======================================" echo "Starting Build 1: Base Image" From c0c80938af9926aa61d67d9a73e4b50c6361e489 Mon Sep 17 00:00:00 2001 From: Dillon Cullinan Date: Thu, 20 Nov 2025 13:30:12 -0500 Subject: [PATCH 2/3] Fix push test Signed-off-by: Dillon Cullinan --- .github/workflows/container-validation-backends.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/container-validation-backends.yml b/.github/workflows/container-validation-backends.yml index d4a2bf85c3..c84c528dab 100644 --- a/.github/workflows/container-validation-backends.yml +++ b/.github/workflows/container-validation-backends.yml @@ -177,7 +177,7 @@ jobs: # if: ${{ github.ref_name == 'main' }} with: local_image: ${{ env.DYNAMO_BASE_IMAGE }} - push_tag: ai-dynamo/dynamo:${{ github.ref_name }}-dynamo-${{ matrix.platform.arch }} + push_tag: ai-dynamo/dynamo:test-dynamo-${{ matrix.platform.arch }} aws_push: 'true' azure_push: 'false' aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }} From bdea27b17f76e33380399b61c335d4d7589e12bd Mon Sep 17 00:00:00 2001 From: Dillon Cullinan Date: Thu, 20 Nov 2025 14:56:45 -0500 Subject: [PATCH 3/3] Revert test to merge-ready logic Signed-off-by: Dillon Cullinan --- .github/workflows/container-validation-backends.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/container-validation-backends.yml b/.github/workflows/container-validation-backends.yml index c84c528dab..1033071468 100644 --- a/.github/workflows/container-validation-backends.yml +++ b/.github/workflows/container-validation-backends.yml @@ -174,10 +174,10 @@ jobs: azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }} - name: Push dynamo base image uses: ./.github/actions/docker-tag-push - # if: ${{ github.ref_name == 'main' }} + if: ${{ github.ref_name == 'main' }} with: local_image: ${{ env.DYNAMO_BASE_IMAGE }} - push_tag: ai-dynamo/dynamo:test-dynamo-${{ matrix.platform.arch }} + push_tag: ai-dynamo/dynamo:${{ github.ref_name }}-dynamo-${{ matrix.platform.arch }} aws_push: 'true' azure_push: 'false' aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}