fv3net environment on apple chips #2258
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhenn
commented
Jun 28, 2023
| @@ -1,9 +1,6 @@ | |||
| channels: | |||
| - conda-forge | |||
| - defaults | |||
| platforms: | |||
There was a problem hiding this comment.
The version of conda-lock we use (0.4.1) was not actually reading this
brianhenn
commented
Jun 28, 2023
| @@ -238,10 +238,9 @@ update_submodules: | |||
| ############################################################ | |||
|
|
|||
| lock_deps: lock_pip | |||
| conda-lock -f environment.yml | |||
| conda-lock render | |||
There was a problem hiding this comment.
The render command and the output it produced (the multi-platform conda-lock.yml file) was not actually used in making our environments.
brianhenn
commented
Jun 28, 2023
| @@ -46,7 +46,7 @@ xpartition>=0.2.1 | |||
| xarray >= 0.19.0 | |||
|
|
|||
| # developer tools | |||
| conda-lock | |||
| conda-lock<1.0.0 | |||
There was a problem hiding this comment.
Requires that we use a version of conda-lock that uses the conda-lock -f environment.yml -p <platform> command to make platform-specific lock files.
Alternatively, we could switch to using a version >=1.0, in which we'd need to use a different conda-lock command (conda render or conda-lock --kind explicit) to implement that approach we've used. See docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds conda fv3net environment installation for Apple chips (M1, etc), since gfortran (a dependency of fv3net) is available for this architecture now. Also clarifies the conda-lock process by removing some extraneous commands and files.
Note: doesn't currently install due to #2266 .
Requirement changes:
make lock_deps/lock_pipfollowing these instructionsResolves #2256.
Coverage reports (updated automatically):