Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider excluding options from CodeModel.get_model_state() #1103

Open
edan-bainglass opened this issue Jan 17, 2025 · 0 comments
Open

Consider excluding options from CodeModel.get_model_state() #1103

edan-bainglass opened this issue Jan 17, 2025 · 0 comments
Assignees

Comments

@edan-bainglass
Copy link
Member

edan-bainglass commented Jan 17, 2025

In the CodeModel class:

    def get_model_state(self) -> dict:
        return {
            "options": self.options,
            "code": self.selected,
            "nodes": self.num_nodes,
            "cpus": self.num_cpus,
            "ntasks_per_node": self.ntasks_per_node,
            "cpus_per_task": self.cpus_per_task,
            "max_wallclock_seconds": self.max_wallclock_seconds,
        }

I added the options field (in #946) surely for some reason, but it doesn't make much sense to me now. This issue is a reminder to revisit the code and see if the field is actually needed, and if possible (strongly suggested), remove it.

@edan-bainglass edan-bainglass self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant