Skip to content

Commit 8a8b504

Browse files
meehandpatchback[bot]
authored andcommitted
Re-backport 10713 - add regression test (#11807)
(cherry picked from commit d66a69e)
1 parent 3e4c3be commit 8a8b504

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

CHANGES/10713.misc.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Optimized web server performance when access logging is disabled by reducing time syscalls -- by :user:`bdraco`.

aiohttp/web_protocol.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ def force_close(self) -> None:
468468
def log_access(
469469
self, request: BaseRequest, response: StreamResponse, time: Optional[float]
470470
) -> None:
471-
if self.access_logger is not None and self.access_logger.enabled:
471+
if self._logging_enabled and self.access_logger is not None:
472472
if TYPE_CHECKING:
473473
assert time is not None
474474
self.access_logger.log(request, response, self._loop.time() - time)

tests/test_web_log.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,6 @@ def log(
283283
assert "This should not be logged" not in caplog.text
284284

285285

286-
@pytest.mark.xfail(reason="#11778")
287286
async def test_logger_does_not_log_when_enabled_post_init(
288287
aiohttp_server: AiohttpServer,
289288
aiohttp_client: AiohttpClient,

0 commit comments

Comments
 (0)