Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web.FileResponse support charset #4559

Open
cole-dda opened this issue Feb 6, 2020 · 1 comment
Open

web.FileResponse support charset #4559

cole-dda opened this issue Feb 6, 2020 · 1 comment

Comments

@cole-dda
Copy link

cole-dda commented Feb 6, 2020

🐣 Is your feature request related to a problem? Please describe.

When send file to browser, browser require charset ,such as:

'text/plain;charset=utf-8' is better than 'text/plain'

'text/html;charset=utf-8' is better than 'text/html'

💡 Describe the solution you'd like

web_fileresponse.py

screenshot_3122

line 323

  charset="utf-8"  #pass by parameter
  self.content_type = ct +";"+charset  # type: ignore

📋 Additional context

@webknjaz
Copy link
Member

webknjaz commented Feb 6, 2020

feel free to send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants