Gracefully handle non-conforming Content-Disposition headers

[tilsche]

Is your feature request related to a problem?

I have encountered servers that send content disposition headers with extra semicolons at the end, e.g.

Content-Disposition: inline; filename="foo.obj";

I understand this is technically non-conforming, but it still contains useful and easily correctly parsable information.

Describe the solution you'd like

aiohttp should gracefully handle minor non-conformance and include the content_disposition with values. It can still emit a warning.

Describe alternatives you've considered

Fixing this in all broken servers is highly unlikely.

Related component

Client

Additional context

Both chromium and wget --content-disposition treat these cases gracefully.

It is a small change to continue here:

aiohttp/aiohttp/multipart.py

Line 112 in a1158c5

return None, {}

Alternative solutions with increasing strictness would be to

1. discard empty parts
2. discard whitespace-only parts
3. discard semicolons at the very end of the header

I'm happy to create a PR with the preferred solution.

Code of Conduct

• I agree to follow the aio-libs Code of Conduct

[asvetlov]

I think option 2 covers most cases.
Pull Request is welcome!