-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unit_converter]: Update unit_converter to API v2.3 #200
[unit_converter]: Update unit_converter to API v2.3 #200
Conversation
1b4112d
to
44d0b4e
Compare
@ManuelSchneid3r is there anything we can do to help this getting merged? Is there any issue with it? |
you could update it to 2.3 |
Have updated extension to API v2.3 and have tested it working locally. Had to nuke my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Thanks for the feedback, should be all resolved as of c2fcbc5 Have tested & all still working. |
Thanks for the update, @Pete-Hamlin ! Unfortunately I get an error when activating the plug-in:
'Typing Extensions' is up to date (4.12.2) |
@hfr-hfr can you try deleting/moving your Something like |
After nuking site-packages and re-installing dependencies for unit_converter, I get a slightly different error:
|
@hfr-hfr please post stdout. It contains a lot of information we would have to ask for. |
And open a new issue. This is a merged PR |
this plugin is heavily overengineered imho and to be honest i am not keen on maintaining it. if anybody is interested, i'd be happy to merge a PR that drops like 300-400 lines of code. |
|
Fix is mentioned in issue above, @Pete-Hamlin 🙏 |
Reopening of #190