Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit_converter]: Update unit_converter to API v2.3 #200

Merged

Conversation

Pete-Hamlin
Copy link
Contributor

Reopening of #190

@hfr-hfr
Copy link

hfr-hfr commented Jul 4, 2024

@ManuelSchneid3r is there anything we can do to help this getting merged? Is there any issue with it?

@ManuelSchneid3r
Copy link
Member

you could update it to 2.3

@ManuelSchneid3r ManuelSchneid3r requested a review from a team July 4, 2024 08:11
@Pete-Hamlin Pete-Hamlin changed the title [unit_converter]: Update unit_converter to API v2.1 [unit_converter]: Update unit_converter to API v2.3 Jul 20, 2024
@Pete-Hamlin
Copy link
Contributor Author

Have updated extension to API v2.3 and have tested it working locally.

Had to nuke my site-packages and do a clean install of dependencies for working with the new API, but seem to have only had to do this once.

Copy link
Member

@ManuelSchneid3r ManuelSchneid3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@Pete-Hamlin
Copy link
Contributor Author

Thanks for the feedback, should be all resolved as of c2fcbc5

Have tested & all still working.

@ManuelSchneid3r ManuelSchneid3r merged commit 109a5cb into albertlauncher:main Aug 14, 2024
@hfr-hfr
Copy link

hfr-hfr commented Aug 21, 2024

Thanks for the update, @Pete-Hamlin !

Unfortunately I get an error when activating the plug-in:

Unit Converter (python.unit_converter):
ImportError: cannot import name 'dataclass_transform' from 'typing_extensions' (/usr/lib/python3/dist-packages/typing_extensions.py)

'Typing Extensions' is up to date (4.12.2)

@Pete-Hamlin
Copy link
Contributor Author

Pete-Hamlin commented Aug 21, 2024

@hfr-hfr can you try deleting/moving your site-packages folder and restarting? This is usually my go to if I'm getting weird dependency errors in albert.

Something like mv .local/share/albert/python/site-packages/ .local/share/albert/python/site-packages.bak/ and see if it sorts itself out?

@hfr-hfr
Copy link

hfr-hfr commented Aug 21, 2024

After nuking site-packages and re-installing dependencies for unit_converter, I get a slightly different error:

Unit Converter (python.unit_converter):
ImportError: cannot import name 'is_typeddict' from 'typing_extensions' (/usr/lib/python3/dist-packages/typing_extensions.py)

@ManuelSchneid3r
Copy link
Member

@hfr-hfr please post stdout. It contains a lot of information we would have to ask for.

@ManuelSchneid3r
Copy link
Member

And open a new issue. This is a merged PR

@ManuelSchneid3r
Copy link
Member

this plugin is heavily overengineered imho and to be honest i am not keen on maintaining it. if anybody is interested, i'd be happy to merge a PR that drops like 300-400 lines of code.

@hfr-hfr
Copy link

hfr-hfr commented Aug 21, 2024

And open a new issue. This is a merged PR

albertlauncher/albert#1423 (comment)

@hfr-hfr
Copy link

hfr-hfr commented Sep 4, 2024

Fix is mentioned in issue above, @Pete-Hamlin 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants