Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jetbrains_projects] Fix Rider config #207

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

albi005
Copy link
Contributor

@albi005 albi005 commented Nov 12, 2024

Copy link
Contributor

@tomsquest tomsquest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah Jetbrains... :/

I would have skipped is_rider and detect it inline in the Editor class, but LGTM.

@danny-isc
Copy link

Is there anything blocking this PR from being merged?

@ManuelSchneid3r
Copy link
Member

At least the fact that api is not compatible. But that's a minor issue. Generally I think there is room for improvement here, but I am busy with core things and actually it works. So for me it is low priority.

@albi005
Copy link
Contributor Author

albi005 commented Mar 8, 2025

What do you mean by "API not compatible"?

Should I remove the is_rider field? I felt like being a bit more explicit was better here, and if there are more edge cases, it can be refactored out. Until then, I think it's fine.

@ManuelSchneid3r
Copy link
Member

What do you mean by "API not compatible"?

https://github.com/albertlauncher/plugins/blob/main/python/albert.pyi

0.27 came with a python api update

@ManuelSchneid3r
Copy link
Member

Ah wait. I clicked view file above and saw the old file. But probably the merge only merges the changes not the entire file.

@ManuelSchneid3r ManuelSchneid3r merged commit a8507e5 into albertlauncher:main Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[jetbrains_projects] Wrong configuration for Rider
4 participants