Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi line does not preserve style #11

Closed
alexandercerutti opened this issue Jan 7, 2024 · 2 comments · May be fixed by #15
Closed

Multi line does not preserve style #11

alexandercerutti opened this issue Jan 7, 2024 · 2 comments · May be fixed by #15
Assignees
@alexandercerutti
Labels
🐛 bug Something isn't working domain:captions-renderer domain:webvtt-adapter 💅 style Issues about cues styling

Comments

@alexandercerutti
Copy link
Owner

alexandercerutti commented Jan 7, 2024 •
edited
Loading

When styling global cues (like with WebVTT), the second row of a cue does not preserve the same style.

Minimum repro case

WEBVTT

STYLE
::cue {
  color: peachpuff;
}

00:00:00.000 --> 00:00:20.000 
Soffro anche un tantino
di sindrome di Tourette.

Result

immagine
alexandercerutti added a commit that referenced this issue Jan 13, 2024
@alexandercerutti
Changed getSubtreeFromCueNodes to render same styles also on new lines (
3c81a4e 
#11)
@alexandercerutti
Copy link
Owner Author

alexandercerutti commented Feb 18, 2024 •
edited
Loading

This issue has been fixed in the feature/ttml-adapter feature. Fixing it, sadly, requires a change of how Entities operate and the re-introduction of Style Entities, that is required to make TTML adapter to work. This means the resolution brings a breaking change. It will fixed in the v2.0.0.

@alexandercerutti alexandercerutti self-assigned this Feb 18, 2024
@alexandercerutti alexandercerutti mentioned this issue Feb 18, 2024
Draft
2 tasks
@alexandercerutti alexandercerutti linked a pull request Feb 18, 2024 that will close this issue
Introduction of support to TTML #15
Draft
2 tasks
@alexandercerutti
Copy link
Owner Author

alexandercerutti commented Feb 8, 2025 •
edited
Loading

Fixed in @sub37/[email protected] without breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandercerutti alexandercerutti

Labels
🐛 bug Something isn't working domain:captions-renderer domain:webvtt-adapter 💅 style Issues about cues styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduction of support to TTML alexandercerutti/sub37
1 participant
@alexandercerutti