fix: pass correct issue id on close issue

alexdor · alexdor · commit e29cd3581868 · 2025-04-14T16:09:53.000+02:00
diff --git a/storer/storer.go b/storer/storer.go
@@ -85,10 +85,10 @@ func UpdateIssues(ctx context.Context, s Storer, currentIssues map[string]Issue,
 				comment.FilePath, comment.LineNumber, comment.LineNumberEnd, err)
 		}
 	}
-	for id := range currentIssues {
-		err := s.CloseIssue(ctx, id)
+	for _, issue := range currentIssues {
+		err := s.CloseIssue(ctx, issue.ID)
 		if err != nil {
-			return fmt.Errorf("failed to delete issue %s : %w", id, err)
+			return fmt.Errorf("failed to delete issue %s : %w", issue.ID, err)
 		}
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,10 @@ func UpdateIssues(ctx context.Context, s Storer, currentIssues map[string]Issue,`
`85`	`85`	`comment.FilePath, comment.LineNumber, comment.LineNumberEnd, err)`
`86`	`86`	`}`
`87`	`87`	`}`
`88`		`- for id := range currentIssues {`
`89`		`- err := s.CloseIssue(ctx, id)`
	`88`	`+ for _, issue := range currentIssues {`
	`89`	`+ err := s.CloseIssue(ctx, issue.ID)`
`90`	`90`	`if err != nil {`
`91`		`- return fmt.Errorf("failed to delete issue %s : %w", id, err)`
	`91`	`+ return fmt.Errorf("failed to delete issue %s : %w", issue.ID, err)`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`	`return nil`