Skip to content

Commit 6365741

Browse files
committed
minor refactoring
1 parent abf4fb7 commit 6365741

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/PTS/DataTransformer/DataTransformer.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,19 @@ public function fillModel(array $dto, $model, string $mapName = 'dto'): void
3434
protected function resolveRefHydrate(array $dto, array $rules): array
3535
{
3636
foreach ($dto as $key => $value) {
37-
if ($value !== null && array_key_exists($key, $rules) && array_key_exists('ref', $rules[$key])) {
37+
if ($value !== null && $this->checkRuleForHydrate($rules, $key)) {
3838
$dto[$key] = $this->hydrateRefValue($this->getRefRules($rules[$key]), $value, $rules[$key]);
3939
}
4040
}
4141

4242
return $dto;
4343
}
4444

45+
protected function checkRuleForHydrate(array $rules, string $key): bool
46+
{
47+
return array_key_exists($key, $rules) && array_key_exists('ref', $rules[$key]);
48+
}
49+
4550
protected function getRefRules(array $rule)
4651
{
4752
return $this->mapsManager->getMap($rule['ref']['model'], $rule['ref']['map']);
@@ -94,8 +99,8 @@ public function toDTO($model, string $mapName = 'dto', array $excludeFields = []
9499
protected function resolveRefExtract(array $dto, array $rules): array
95100
{
96101
foreach ($dto as $key => $value) {
97-
$rule = $rules[$key];
98-
if ($value !== null && array_key_exists('ref', $rule)) {
102+
if ($value !== null && $this->checkRuleForHydrate($rules, $key)) {
103+
$rule = $rules[$key];
99104
$refRules = $this->mapsManager->getMap($rule['ref']['model'], $rule['ref']['map']);
100105
$refDTO = $this->extractRefValue($refRules, $value, $rule);
101106
$dto[$key] = $refDTO;

0 commit comments

Comments
 (0)