stability improvements

Author: algonautshant

agreement/asyncVoteVerifier_test.go

@@ -88,11 +88,11 @@ func BenchmarkAsyncVerification(b *testing.B) {
 	errProbs := []float32{0.0, 0.2, 0.8}
 	for _, errProb := range errProbs {
 		b.Run(fmt.Sprintf("errProb_%.3f_any_err", errProb), func(b *testing.B) {
-			sendReceiveVoteVerifications(false, errProb, b.N, b.N, b)
+			sendReceiveVoteVerifications(false, errProb, b.N/2, b.N/2, b)
 		})
 		if errProb > float32(0.0) {
 			b.Run(fmt.Sprintf("errProb_%.3f_sig_err_only", errProb), func(b *testing.B) {
-				sendReceiveVoteVerifications(true, errProb, b.N, b.N, b)
+				sendReceiveVoteVerifications(true, errProb, b.N/2, b.N/2, b)
 			})
 		}
 	}
@@ -134,6 +134,9 @@ func min(a, b int) int {
 }
 
 func sendReceiveVoteVerifications(badSigOnly bool, errProb float32, count, eqCount int, tb testing.TB) {
+	if count+eqCount < 10 {
+		return
+	}
 	voteVerifier := MakeAsyncVoteVerifier(nil)
 	defer voteVerifier.Quit()
 
@@ -217,13 +220,15 @@ func generateTestVotes(onlyBadSigs bool, errChan chan<- error, count, eqCount in
 	wg := sync.WaitGroup{}
 	vg := makeTestVoteGenerator()
 
+	nextErrType := 0
 	for c := 0; c < count; c++ {
 		errType := 99
 		if rand.Float32() < errProb {
 			if onlyBadSigs {
 				errType = 0
 			} else {
-				errType = rand.Intn(7)
+				errType = nextErrType
+				nextErrType = (nextErrType + 1) % (vg.voteOptions() - 1)
 			}
 		}
 		v, err := vg.getTestVote(errType)
@@ -234,14 +239,16 @@ func generateTestVotes(onlyBadSigs bool, errChan chan<- error, count, eqCount in
 		votes[v.id] = v
 	}
 
+	nextErrType = 0
 	vg.counter = 0
 	for c := 0; c < eqCount; c++ {
 		errType := 99
 		if rand.Float32() < errProb {
 			if onlyBadSigs {
 				errType = 0
 			} else {
-				errType = rand.Intn(9)
+				errType = nextErrType
+				nextErrType = (nextErrType + 1) % (vg.voteEqOptions() - 1)
 			}
 		}
 		v, err := vg.getTestEqVote(errType)
@@ -447,14 +454,14 @@ func (vg *testVoteGenerator) getTestEqVote(errType int) (v *unEqVoteTest, err er
 
 	switch errType {
 	case 0:
-		// check for same vote
-		v = &unEqVoteTest{uev: &evSameVote, err: fmt.Errorf("error same vote"), id: c}
-
-	case 1:
 		badSig := ev
 		badSig.Sigs[0].Sig[0] = badSig.Sigs[0].Sig[0] + 1
 		v = &unEqVoteTest{uev: &badSig, err: fmt.Errorf("error bad sig"), id: c}
 
+	case 1:
+		// check for same vote
+		v = &unEqVoteTest{uev: &evSameVote, err: fmt.Errorf("error same vote"), id: c}
+
 	case 2:
 		noCred := ev
 		noCred.Cred = committee.UnauthenticatedCredential{}

agreement/common_test.go

@@ -325,7 +325,7 @@ func (l *testLedger) LookupAgreement(r basics.Round, a basics.Address) (basics.O
 
 	if r >= l.nextRound {
 		err := fmt.Errorf("Lookup called on future round: %v >= %v! (this is probably a bug)", r, l.nextRound)
-		panic(err)
+		return basics.OnlineAccountData{}, err
 	}
 
 	if l.maxNumBlocks != 0 && r+round(l.maxNumBlocks) < l.nextRound {