Revert Box Application Pagination support. (#983)

Author: gmalouf

src/client/v2/algod/getApplicationBoxes.ts

@@ -9,7 +9,7 @@ import { BoxesResponse } from './models/types.js';
  * #### Example
  * ```typescript
  * const index = 60553466;
- * const boxesResponse = await algodClient.getApplicationBoxes(index).prefix('int:1234').next('b64:A==').values(true).do();
+ * const boxesResponse = await algodClient.getApplicationBoxes(index).max(3).do();
  * const boxNames = boxesResponse.boxes.map(box => box.name);
  * ```
  *
@@ -53,66 +53,6 @@ export default class GetApplicationBoxes extends JSONRequest<BoxesResponse> {
     return this;
   }
 
-  /**
-   * A box name prefix, in the goal app call arg form 'encoding:value'. For ints, use the form 'int:1234'. For raw bytes, use the form 'b64:A=='. For printable strings, use the form 'str:hello'. For addresses, use the form 'addr:XYZ...'.
-   *
-   * #### Example
-   * ```typescript
-   * const prefix = 'int:1234';
-   * const boxesResult = await algodClient
-   *        .GetApplicationBoxes(1234)
-   *        .prefix(prefix)
-   *        .do();
-   * ```
-   *
-   * @param prefix - the box name prefix in the form 'encoding:value'
-   * @category query
-   */
-  prefix(prefix: string) {
-    this.query.prefix = prefix;
-    return this;
-  }
-
-  /**
-   * A box name, in the goal app call arg form 'encoding:value'. When provided, the returned boxes begin (lexographically) with the supplied name. Callers may implement pagination by reinvoking the endpoint with the token from a previous call's next-token.
-   *
-   * #### Example
-   * ```typescript
-   * const next = 'int:1234';
-   * const boxesResult = await algodClient
-   *        .GetApplicationBoxes(1234)
-   *        .next(next)
-   *        .do();
-   * ```
-   *
-   * @param next - the next box name for pagination, in the goal app call arg form 'encoding:value'
-   * @category query
-   */
-  next(next: string) {
-    this.query.next = next;
-    return this;
-  }
-
-  /**
-   * If true, box values will be returned.
-   *
-   * #### Example
-   * ```typescript
-   * const values = true;
-   * const boxesResult = await algodClient
-   *        .GetApplicationBoxes(1234)
-   *        .values(values)
-   *        .do();
-   * ```
-   *
-   * @param values - if true, box values will be returned
-   * @category query
-   */
-  values(values: boolean) {
-    this.query.values = values;
-    return this;
-  }
-
   // eslint-disable-next-line class-methods-use-this
   prepare(response: HTTPClientResponse): BoxesResponse {
     return decodeJSON(response.getJSONText(), BoxesResponse);

src/client/v2/algod/models/types.ts

@@ -2157,17 +2157,9 @@ module.exports = function getSteps(options) {
   );
 
   When(
-    'we make a GetApplicationBoxes call for applicationID {int} with max {int} prefix {string} next {string} values {string}',
-    async function (index, limit, prefix, next, valuesAsString) {
-      const values = valuesAsString === 'true';
-
-      await this.v2Client
-        .getApplicationBoxes(index)
-        .max(limit)
-        .prefix(prefix)
-        .next(next)
-        .values(values)
-        .doRaw();
+    'we make a GetApplicationBoxes call for applicationID {int} with max {int}',
+    async function (index, limit) {
+      await this.v2Client.getApplicationBoxes(index).max(limit).doRaw();
     }
   );
 
@@ -5147,58 +5139,13 @@ module.exports = function getSteps(options) {
     }
   );
 
-  async function advanceChainWaitForBox(
-    algodClient,
-    account,
-    appIndex,
-    boxLength
-  ) {
-    // balancesFlushInterval in algod is 5 seconds, so we need at least that amount of time to pass to trigger the flush we need
-    // eslint-disable-next-line no-promise-executor-return
-    const sleep = (ms) => new Promise((r) => setTimeout(r, ms));
-    /* eslint-disable no-await-in-loop */
-    for (let i = 0; i < 50; i++) {
-      const sp = await algodClient.getTransactionParams().do();
-      const algoTxn = algosdk.makePaymentTxnWithSuggestedParamsFromObject({
-        sender: account.addr,
-        receiver: account.addr,
-        amount: 0,
-        suggestedParams: sp,
-      });
-
-      const algoStxn = algoTxn.signTxn(account.sk);
-      await algodClient.sendRawTransaction(algoStxn).do();
-
-      // MaxAccountLookback is 4, we start checking for our boxes after the 5th round from create transaction
-      if (i > 5) {
-        const resp = await algodClient.getApplicationBoxes(appIndex).do();
-
-        // If the boxes have shown up, break out of loop
-        if (resp.boxes.length === boxLength) {
-          break;
-        } else {
-          await sleep(1000); // Sleep then continue
-        }
-      }
-    }
-    /* eslint-enable no-await-in-loop */
-  }
-
   Then(
     'according to {string}, the current application should have the following boxes {string}.',
     async function (fromClient, boxNames) {
       const boxes = splitBoxNames(boxNames);
 
       let resp = null;
       if (fromClient === 'algod') {
-        // We need to advance a few rounds so that app boxes endpoint returns expected boxes (
-        // it only pulls persisted data, so need to get past MaxAccountLookback and flush after)
-        await advanceChainWaitForBox(
-          this.v2Client,
-          this.transientAccount,
-          this.currentApplicationIndex,
-          boxes.length
-        );
         resp = await this.v2Client
           .getApplicationBoxes(this.currentApplicationIndex)
           .do();