Merge pull request #104 from aligent/feature/product-option-values-improvements

Feature/product option values improvements

Author: jswift

src/BigCommerce/Api/Catalog/Products/ProductOption/ProductOptionValuesApi.php

@@ -7,6 +7,12 @@
 use BigCommerce\ApiV3\ResponseModels\Product\ProductOptionValueResponse;
 use BigCommerce\ApiV3\ResponseModels\Product\ProductOptionValuesResponse;
 
+/**
+ * Referred to in the documentation as Product Variant Options Values
+ *
+ * https://developer.bigcommerce.com/api-reference/store-management/catalog/product-variant-option-values/createoptionvalue
+ *
+ */
 class ProductOptionValuesApi extends ResourceApi
 {
     private int $productId;

src/BigCommerce/ResponseModels/OptionsResponse.php

@@ -7,23 +7,16 @@
 
 class OptionsResponse extends PaginatedResponse
 {
-    /**
-     * @var ProductOption[]
-     */
-    private array $options;
-
     /**
      * @return ProductOption[]
      */
     public function getOptions(): array
     {
-        return $this->options;
+        return $this->getData();
     }
 
-    protected function addData(array $data): void
+    protected function resourceClass(): string
     {
-        $this->options = array_map(function (\stdClass $o) {
-            return new ProductOption($o);
-        }, $data);
+        return ProductOption::class;
     }
 }

tests/BigCommerce/Api/Catalog/Products/ProductOption/ProductOptionValuesApiTest.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace BigCommerce\Tests\Api\Catalog\Products\ProductOption;
+
+use BigCommerce\ApiV3\ResourceModels\Catalog\Product\ProductOptionValue;
+use BigCommerce\Tests\BigCommerceApiTest;
+
+class ProductOptionValuesApiTest extends BigCommerceApiTest
+{
+    public function testHasProductIdAndOptionIdOnCreate(): void
+    {
+        $this->setReturnData('catalog__products__1__options__2__values__create.json');
+        $productId = 1;
+        $optionId = 2;
+
+        $optionValue = new ProductOptionValue();
+        $optionValue->sort_order = 2;
+        $optionValue->is_default = true;
+        $optionValue->label      = 'Colors';
+        $optionValue->value_data = (object)[
+            "colors" => ["#123c91, #FFFF00, #397a44"]
+        ];
+
+        $productOptionValuesApi = $this->getApi()->catalog()->product($productId)->option($optionId)->values();
+        $this->assertEquals($productId, $productOptionValuesApi->getProductId(), 'Product ID not set correctly');
+        $this->assertEquals($optionId, $productOptionValuesApi->getParentResourceId(), 'Option ID not set correctly');
+        $productOptionValuesApi->create($optionValue);
+        $this->assertEquals("catalog/products/{$productId}/options/{$optionId}/values", $this->getLastRequestPath());
+    }
+}

tests/BigCommerce/responses/catalog__products__1__options__2__values__create.json

@@ -0,0 +1,13 @@
+{
+  "data": {
+    "id": 44,
+    "label": "Pick a color",
+    "sort_order": 9,
+    "value_data": {
+      "colors": [
+        "#123c91, #FFFF00, #397a44"
+      ]
+    },
+    "is_default": false
+  }
+}