-
Notifications
You must be signed in to change notification settings - Fork 2
Labels
bugSomething isn't workingSomething isn't working
Description
Great to see the 'extend session' warning modal! Thanks for adding that!
One issue with the modal: it flashes and then disappears during page load, causing some layout shift. Can you add display: none or similar to hide it during load until the modal is initialized, to prevent that?
magento2-pci-4-compatibility/view/adminhtml/templates/modal.phtml
Lines 20 to 30 in e772d27
| <div id="session-expire-warning-modal"> | |
| <p style="font-size:48px;color:#FF0000">⚠</p> | |
| <p id="session-warning-message"> | |
| <?= __( | |
| 'Your session will expire in one minute. ' . | |
| 'Please save your changes or extend your session to continue working.' | |
| ) ?> | |
| </p> | |
| <input type="hidden" id="session-extend-url" value="<?= $escaper->escapeUrl($extendSessionUrl) ?>"/> | |
| <input type="hidden" id="session-lifetime" value="<?= $escaper->escapeHtmlAttr((string)$sessionLifetime) ?>"/> | |
| </div> |
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working