Skip to content

CLS issue on warning modal #16

@rhoerr

Description

@rhoerr

Great to see the 'extend session' warning modal! Thanks for adding that!

One issue with the modal: it flashes and then disappears during page load, causing some layout shift. Can you add display: none or similar to hide it during load until the modal is initialized, to prevent that?

ref: #14 #15

<div id="session-expire-warning-modal">
<p style="font-size:48px;color:#FF0000">&#x26A0;</p>
<p id="session-warning-message">
<?= __(
'Your session will expire in one minute. ' .
'Please save your changes or extend your session to continue working.'
) ?>
</p>
<input type="hidden" id="session-extend-url" value="<?= $escaper->escapeUrl($extendSessionUrl) ?>"/>
<input type="hidden" id="session-lifetime" value="<?= $escaper->escapeHtmlAttr((string)$sessionLifetime) ?>"/>
</div>

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions