Remove timber (#603)

Remove Timber

Author: chirag-jn

build.gradle

@@ -84,10 +84,12 @@ android {
     buildTypes {
         betaRelease {
             signingConfig signingConfigs.debug
+            debuggable false
         }
 
         release {
             signingConfig signingConfigs.release
+            debuggable false
         }
     }
 
@@ -142,7 +144,6 @@ dependencies {
     implementation 'com.google.android.gms:play-services-cast-framework:11.6.0'
     implementation 'com.amulyakhare:com.amulyakhare.textdrawable:1.0.1'
     implementation 'com.github.dmytrodanylyk.android-process-button:library:1.0.4'
-    implementation 'com.jakewharton.timber:timber:4.7.1'
 
 //    Otto and Retrofit
     implementation 'com.squareup:otto:1.3.8'

src/main/java/org/amahi/anywhere/AmahiApplication.java

@@ -42,7 +42,6 @@
 import org.amahi.anywhere.server.Api;
 
 import dagger.ObjectGraph;
-import timber.log.Timber;
 
 /**
  * Application declaration. Basically sets things up at the startup time,
@@ -72,7 +71,7 @@ public void onCreate() {
         super.onCreate();
 
         instance = this;
-        setUpLogging();
+
         setUpDetecting();
 
         setUpInjections();
@@ -86,12 +85,6 @@ public void onCreate() {
         }
     }
 
-    private void setUpLogging() {
-        if (isDebugging()) {
-            Timber.plant(new Timber.DebugTree());
-        }
-    }
-
     private void setUpTheme() {
         SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(this);
         this.isLightThemeEnabled = preferences.getBoolean(getString(R.string.pref_key_light_theme), false);

src/main/java/org/amahi/anywhere/activity/ServerFilesActivity.java

@@ -33,6 +33,7 @@
 import android.os.IBinder;
 import android.preference.PreferenceManager;
 import android.provider.MediaStore;
+import android.util.Log;
 import android.view.MenuItem;
 import android.view.View;
 import android.widget.FrameLayout;
@@ -100,7 +101,6 @@
 
 import pub.devrel.easypermissions.AppSettingsDialog;
 import pub.devrel.easypermissions.EasyPermissions;
-import timber.log.Timber;
 
 /**
  * Files activity. Shows files navigation and operates basic file actions,
@@ -113,6 +113,8 @@ public class ServerFilesActivity extends AppCompatActivity implements
     CastStateListener,
     AlertDialogFragment.DuplicateFileDialogCallback {
 
+    public static final String TAG = ServerFilesActivity.class.getSimpleName();
+
     private static final int FILE_UPLOAD_PERMISSION = 102;
     private static final int CAMERA_PERMISSION = 103;
     private static final int REQUEST_UPLOAD_IMAGE = 201;
@@ -438,7 +440,7 @@ private void openCamera() {
                 cameraIntent.putExtra(MediaStore.EXTRA_OUTPUT, photoURI);
                 startActivityForResult(cameraIntent, REQUEST_CAMERA_IMAGE);
             } catch (IOException ex) {
-                Timber.d(ex);
+                Log.d(TAG, ex.getMessage());
             }
         }
     }

src/main/java/org/amahi/anywhere/fragment/ServerAppsFragment.java

@@ -47,7 +47,6 @@
 import org.amahi.anywhere.server.client.ServerClient;
 import org.amahi.anywhere.server.model.ServerApp;
 import org.amahi.anywhere.util.ViewDirector;
-import org.jetbrains.annotations.NotNull;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -234,7 +233,7 @@ public void onPause() {
     }
 
     @Override
-    public void onSaveInstanceState(@NotNull Bundle outState) {
+    public void onSaveInstanceState(Bundle outState) {
         super.onSaveInstanceState(outState);
 
         tearDownAppsState(outState);

src/main/java/org/amahi/anywhere/server/ApiConnectionDetector.java

@@ -19,10 +19,9 @@
 
 package org.amahi.anywhere.server;
 
-import android.content.res.Resources;
 import android.net.Uri;
+import android.util.Log;
 
-import org.amahi.anywhere.R;
 import org.amahi.anywhere.server.model.ServerRoute;
 import org.amahi.anywhere.util.Constants;
 
@@ -33,13 +32,15 @@
 import okhttp3.OkHttpClient;
 import okhttp3.Request;
 import okhttp3.Response;
-import timber.log.Timber;
 
 /**
  * API connection guesser. Tries to connect to the server address to determine if it is available
  * and returns it if succeed or another one otherwise.
  */
 public class ApiConnectionDetector {
+
+    public static final String TAG = ApiConnectionDetector.class.getSimpleName();
+
     private OkHttpClient httpClient;
 
     public ApiConnectionDetector() {
@@ -54,7 +55,7 @@ private OkHttpClient buildHttpClient() {
     }
 
     public String detect(ServerRoute serverRoute) {
-        Timber.tag(Constants.connection);
+        Log.d(TAG, Constants.connection);
 
         try {
             Request httpRequest = new Request.Builder()
@@ -67,11 +68,11 @@ public String detect(ServerRoute serverRoute) {
 
             httpResponse.body().close();
 
-            Timber.d("Using local address.");
+            Log.d(TAG, "Using local address.");
 
             return serverRoute.getLocalAddress();
         } catch (IOException e) {
-            Timber.d("Using remote address.");
+            Log.d(TAG, "Using remote address.");
 
             return serverRoute.getRemoteAddress();
         }