chore: Improve Code Style (#15)

Co-authored-by: Amin Alaee <[email protected]>

Author: yezz123

.codecov.yml

@@ -1 +1,8 @@
-comment: off
+coverage:
+  status:
+    project:
+      default:
+        target: auto
+        threshold: 1%
+
+comment: false

sqladmin/fields.py

@@ -341,7 +341,7 @@ def _get_object_list(self) -> List[tuple]:
         if self._object_list is None:
             query = self.query if self.query is not None else self.query_factory()
             get_pk = self.get_pk
-            self._object_list = list((str(get_pk(obj)), obj) for obj in query)
+            self._object_list = [(str(get_pk(obj)), obj) for obj in query]
         return self._object_list
 
     def iter_choices(self) -> Generator[Tuple[str, str, bool], None, None]:
@@ -434,7 +434,7 @@ def pre_validate(self, form: Form) -> None:
         if self._invalid_formdata:
             raise ValidationError(self.gettext("Not a valid choice"))
         elif self.data:
-            obj_list = list(x[1] for x in self._get_object_list())
+            obj_list = [x[1] for x in self._get_object_list()]
             for v in self.data:
                 if v not in obj_list:
                     raise ValidationError(self.gettext("Not a valid choice"))

sqladmin/models.py

@@ -48,7 +48,7 @@ class ModelAdminMeta(type):
     def __new__(mcls, name, bases, attrs: dict, **kwargs: Any):
         cls: Type["ModelAdmin"] = super().__new__(mcls, name, bases, attrs)
 
-        model = kwargs.get("model", None)
+        model = kwargs.get("model")
 
         if not model:
             return cls
@@ -68,7 +68,7 @@ def __new__(mcls, name, bases, attrs: dict, **kwargs: Any):
 
         cls.name = attrs.get("name", prettify_class_name(cls.model.__name__))
         cls.name_plural = attrs.get("name_plural", f"{cls.name}s")
-        cls.icon = attrs.get("icon", None)
+        cls.icon = attrs.get("icon")
 
         mcls._check_conflicting_options(["column_list", "column_exclude_list"], attrs)
         mcls._check_conflicting_options(
@@ -249,11 +249,10 @@ def get_details_columns(cls) -> List[Tuple[str, Column]]:
 
     @classmethod
     def get_column_labels(cls) -> Dict[Column, str]:
-        column_labels = {}
-        for column_label, value in cls.column_labels.items():
-            column_labels[cls.get_column_by_attr(column_label)] = value
-
-        return column_labels
+        return {
+            cls.get_column_by_attr(column_label): value
+            for column_label, value in cls.column_labels.items()
+        }
 
     @classmethod
     async def delete_model(cls, obj: str) -> None: