Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcategory as separate key #11

Open
groenroos opened this issue Sep 12, 2019 · 4 comments
Open

Subcategory as separate key #11

groenroos opened this issue Sep 12, 2019 · 4 comments

Comments

@groenroos
Copy link

It's handy having the subcategory included in the 'full' JSON, but putting it in the category string means it's much more difficult to separate the emojis into separated categories on user-facing applications (who want the major categories, but likely not so much the subcategories). Could the subcategory be put into a separate subcategory property?

@amio
Copy link
Owner

amio commented Sep 13, 2019

That's nice to have

@amio
Copy link
Owner

amio commented Sep 13, 2019

Actually, I've think about change the key to group (and subgroup), to match with wording in official tests, and having a smaller json file size as bonus.

For now I just kept category for compatibility. Maybe it's better to introduce this change with subgroup in v13 🤔

@groenroos
Copy link
Author

I agree that group and subgroup would be better for consistency, and that that should be introduced in 13.x.x since it would be an incompatible change.

Filesize is becoming increasingly irrelevant these days, but there's always JSONH for those worried about it! 🙂

xDEADC0DE pushed a commit to xDEADC0DE/emoji.json that referenced this issue Jan 23, 2020
@amio amio closed this as completed in cce8744 Jan 26, 2020
@amio
Copy link
Owner

amio commented Jan 26, 2020

Let's add group and subgroup now, and

  • remove category in v13

@amio amio reopened this Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants