Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords #12

Open
groenroos opened this issue Sep 12, 2019 · 7 comments
Open

Keywords #12

groenroos opened this issue Sep 12, 2019 · 7 comments

Comments

@groenroos
Copy link

Jump from 12.0.0 to 12.1.0 seems to have lost the keywords property in the JSON; is there a way to get that back, so that the emojis remain more searchable?

@amio
Copy link
Owner

amio commented Sep 13, 2019

Since 12.1.0, the json is generated from emoji-test.text, there's no keywords info in that source file now.

@amio amio closed this as completed Sep 13, 2019
@groenroos
Copy link
Author

I understand it's not available in the source file. However, the keywords are available in XML format in the CLDR repo. I think it could be worth it to look into incorporating this data into the generator script.

The keywords and emoji names are even available in multiple languages in that directory, so even #6 could potentially be addressed if this data source was matched and merged with the emoji-test.txt source.

@amio
Copy link
Owner

amio commented Sep 13, 2019

That's informative! thanks @groenroos 👍

@amio amio reopened this Sep 13, 2019
@rainypixels
Copy link

@amio Any near-term plans to support a keyword merge with the CLDR xml as @groenroos recommended?

@amio
Copy link
Owner

amio commented Nov 4, 2019

@rainypixels Kinda busy recently, I might have time on this in a month. While PR is welcome also :D

@rainypixels
Copy link

@amio Thanks for the quick response. OK, I'll see if we can add it to our backlog before then to do a PR. 🤞

@angelofan
Copy link

I understand it's not available in the source file. However, the keywords are available in XML format in the CLDR repo. I think it could be worth it to look into incorporating this data into the generator script.

The keywords and emoji names are even available in multiple languages in that directory, so even #6 could potentially be addressed if this data source was matched and merged with the emoji-test.txt source.

I found the CLDR repository in json format.

I tried adding a part in the script that extracts localized data.

There are many emojis missing from CLDR, especially some skin tone variants. For example, there is no data for these expressions in en.json : 🤚🏻, 🤚🏼, 🤚🏽, 🤚🏾, 🤚🏿, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants