באג ב`/files`

[amirbiron]

בווב אפ בעמוד "כל הקבצים" פתאום רשום לכל כרטיס קובץ "0 שורות" , 0 B"
והבעיה היא רק בעמוד כל הקבצים, בשאר העמודים הכרטיסי קובץ מציגים את כל הנתונים

ובלוגים לא מצאתי משהו מיוחד:

 - app - INFO - FILES_HANDLER_ENTERED build=33dfc093 host=srv-d2tpio95pdvs739q1i9g-57f8df45b-cclm8 pid=71 request_id=None
2026-02-20 05:05:57,988 - app - WARNING - files.aggregate_memory_limit request_id=None fallback=find code=292
Menu
2026-02-20 05:05:59,875 - database.manager - WARNING - slow_mongo
{"query_id": "5c3429542f2a831a", "collection": "code_snippets", "operation": "find", "execution_time_ms": 1886.67, "query_shape": {"user_id": "<value>", "$and": [{"is_active": "<value>"}]}, "event": "slow_query_detected", "user_id": "533084436e046e6d", "queue_delay": 1, "request_id": "00d39d36", "command": "webapp:get:files_page", "queue_delay_source": "X-Request-Start", "schema_version": "1.0", "level": "warning", "timestamp": "2026-02-20T05:05:59.876642Z"}
2026-02-20 05:06:00,681 - app - WARNING - files.aggregate_fallback_used request_id=None scanned=120 returned=21
2026-02-20 05:06:01,499 - app - WARNING - slow_request
{"request_id": "8ad28c70", "method": "GET", "path": "/api/v1/announcements/active", "handler": "api_active_announcement", "status_code": 200, "duration_ms": 265, "queue_delay": 3, "queue_delay_source": "X-Request-Start", "event": "access_logs", "user_id": "533084436e046e6d", "command": "webapp:get:api_active_announcement", "schema_version": "1.0", "level": "info", "timestamp": "2026-02-20T05:06:02.650599Z"}
2026-02-20 05:06:03,561 - app - WARNING - slow_request
{"request_id": "97787682", "method": "GET", "path": "/api/collections/tags/metadata", "handler": "collections.get_tags_metadata", "status_code": 200, "duration_ms": 1175, "queue_delay": 2, "queue_delay_source": "X-Request-Start", "event": "access_logs", "user_id": "533084436e046e6d", "command": "webapp:get:collections.get_tags_metadata", "schema_version": "1.0", "level": "info", "timestamp": "2026-02-20T05:06:03.562974Z"}
2026-02-20 05:06:05,887 - app - INFO - FILES_HANDLER_ENTERED build=33dfc093 host=srv-d2tpio95pdvs739q1i9g-57f8df45b-cclm8 pid=71 request_id=None
{"request_id": "7c837f5f", "method": "POST", "path": "/api/ui_prefs", "handler": "api_ui_prefs", "status_code": 200, "duration_ms": 270, "queue_delay": 3, "queue_delay_source": "X-Request-Start", "event": "access_logs", "user_id": "533084436e046e6d", "command": "webapp:post:api_ui_prefs", "schema_version": "1.0", "level": "info", "timestamp": "2026-02-20T05:06:06.157681Z"}
2026-02-20 05:06:06,490 - app - WARNING - files.aggregate_memory_limit request_id=None fallback=find code=292
2026-02-20 05:06:08,480 - database.manager - WARNING - slow_mongo
{"query_id": "3d69d0474cebab12", "collection": "code_snippets", "operation": "find", "execution_time_ms": 1989.417, "query_shape": {"user_id": "<value>", "$and": [{"is_active": "<value>"}, {"$or": [{"created_at": {"$lt": "<value>"}}, {"$and": [{"created_at": {"$eq": "<value>"}}, {"_id": {"$lt": "<value>"}}]}]}]}, "event": "slow_query_detected", "user_id": "533084436e046e6d", "queue_delay": 0, "request_id": "b3f784cf", "command": "webapp:get:files_page", "queue_delay_source": "X-Request-Start", "schema_version": "1.0", "level": "warning", "timestamp": "2026-02-20T05:06:08.481315Z"}
2026-02-20 05:06:09,289 - app - WARNING - files.aggregate_fallback_used request_id=None scanned=120 returned=21
2026-02-20 05:06:10,096 - app - WARNING - slow_request
{"request_id": "18d7e9d7", "method": "GET", "path": "/api/sticky-notes/reminders/summary", "handler": "sticky_notes.reminders_summary", "status_code": 200, "duration_ms": 279, "queue_delay": 3, "queue_delay_source": "X-Request-Start", "event": "access_logs", "user_id": "533084436e046e6d", "command": "webapp:get:sticky_notes.reminders_summary", "schema_version": "1.0", "level": "info", "timestamp": "2026-02-20T05:06:10.803607Z"}
{"request_id": "abd8832f", "method": "GET", "path": "/static/data/commands.json", "handler": "static", "status_code": 200, "duration_ms": 0, "queue_delay": 0, "queue_delay_source": "X-Request-Start", "event": "access_logs", "user_id": "533084436e046e6d", "command": "webapp:get:static", "schema_version": "1.0", "level": "info", "timestamp": "2026-02-20T05:06:10.813162Z"}
2026-02-20 05:06:12,001 - app - WARNING - slow_request
{"request_id": "e0110444", "method": "GET", "path": "/api/collections/tags/metadata", "handler": "collections.get_tags_metadata", "status_code": 200, "duration_ms": 1173, "queue_delay": 2, "queue_delay_source": "X-Request-Start", "event": "access_logs", "user_id": "533084436e046e6d", "command": "webapp:get:collections.get_tags_metadata", "schema_version": "1.0", "level": "info", "timestamp": "2026-02-20T05:06:12.002501Z"}
{"request_id": "b6b30069", "method": "GET", "path": "/sw.js", "handler": "service_worker_js", "status_code": 200, "duration_ms": 0, "queue_delay": 3, "queue_delay_source": "X-Request-Start", "event": "access_logs", "user_id": "533084436e046e6d", "command": "webapp:get:service_worker_js", "schema_version": "1.0", "level": "info", "timestamp": "2026-02-20T05:06:12.725284Z"}
2026-02-20 05:06:14,210 - app - INFO - FILES_HANDLER_ENTERED build=33dfc093 host=srv-d2tpio95pdvs739q1i9g-57f8df45b-cclm8 pid=71 request_id=None
2026-02-20 05:06:14,806 - app - WARNING - files.aggregate_memory_limit request_id=None fallback=find code=292
2026-02-20 05:06:16,682 - database.manager - WARNING - slow_mongo
{"query_id": "5c3429542f2a831a", "collection": "code_snippets", "operation": "find", "execution_time_ms": 1875.763, "query_shape": {"user_id": "<value>", "$and": [{"is_active": "<value>"}]}, "event": "slow_query_detected", "user_id": "533084436e046e6d", "queue_delay": 2, "request_id": "dd5086f2", "command": "webapp:get:files_page", "queue_delay_source": "X-Request-Start", "schema_version": "1.0", "level": "warning", "timestamp": "2026-02-20T05:06:16.683797Z"}
2026-02-20 05:06:17,496 - app - WARNING - files.aggregate_fallback_used request_id=None scanned=120 returned=21
2026-02-20 05:06:18,302 - app - WARNING - slow_request
{"request_id": "dd5086f2", "method": "GET", "path": "/files", "handler": "files_page", "status_code": 200, "duration_ms": 4091, "queue_delay": 2, "queue_delay_source": "X-Request-Start", "event": "access_logs", "user_id": "533084436e046e6d", "command": "webapp:get:files_page", "schema_version": "1.0", "level": "info", "timestamp": "2026-02-20T05:06:18.303774Z"}
2026-02-20 05:06:20,395 - app - WARNING - slow_request

[amirbiron]

@cursoragent

תוכל לבדוק מה הבעיה?

[cursor]

כן—מצאתי את הבעיה וגם תיקנתי.

מה קרה ולמה זה רק ב־/files

• ב־/files יש מסלול fallback שמופעל כש־Mongo זורק OperationFailure עם קוד 292 (ExceededMemoryLimit) ואז עוברים מ־aggregate ל־find.
• במסלול ה־fallback הזה, למסמכים ישנים חסרים השדות file_size / lines_count (הם נוספו בשלב מאוחר יותר), ולכן ה־UI נופל ל־0 ומציג “0 שורות / 0 B”. בעמודים אחרים זה לא קורה כי שם עדיין עושים aggregate שמחשב את השדות ב־DB.

מה שיניתי

• webapp/app.py: בתוך _fallback_files_created_at_page הוספתי השלמה בטוחה של file_size/lines_count למסמכים שחסרים אותם, באמצעות aggregate קטן לפי _id (בלי להחזיר code למסך הרשימה).
• tests/test_webapp_files_aggregate_allow_disk_use.py: הוספתי טסט שמדמה OperationFailure(code=292) ומוודא שב־fallback עדיין רואים גודל ושורות תקינים.

סטטוס

• העליתי commit והדפתי לענף cursor/files-page-data-issue-de42.
• הרצת הטסט הממוקד עברה בהצלחה.