fix(session replay): provide default for db

Author: Kelly Wallach

packages/session-replay-browser/src/targeting/targeting-idb-store.ts

@@ -13,7 +13,7 @@ export interface SessionReplayTargetingDB extends DBSchema {
 }
 
 export class TargetingIDBStore {
-  dbs: { [apiKey: string]: IDBPDatabase<SessionReplayTargetingDB> } | undefined;
+  dbs: { [apiKey: string]: IDBPDatabase<SessionReplayTargetingDB> } = {};
 
   createStore = async (dbName: string) => {
     return await openDB<SessionReplayTargetingDB>(dbName, 1, {
@@ -33,10 +33,7 @@ export class TargetingIDBStore {
     }
     const dbName = `${apiKey.substring(0, 10)}_amp_session_replay_targeting`;
     const db = await this.createStore(dbName);
-    this.dbs = {
-      ...this.dbs,
-      [apiKey]: db,
-    };
+    this.dbs[apiKey] = db;
     return db;
   };
 

packages/targeting/src/targeting.ts

@@ -1,8 +1,4 @@
 import { EvaluationEngine } from '@amplitude/experiment-core';
-<<<<<<< HEAD
-=======
-import { targetingIDBStore } from './targeting-idb-store';
->>>>>>> 7ea29d5c (fix(targeting): keep track of open db instances and ensure deduplication of events)
 import { Targeting as AmplitudeTargeting, TargetingParameters } from './typings/targeting';
 
 export class Targeting implements AmplitudeTargeting {
@@ -12,32 +8,7 @@ export class Targeting implements AmplitudeTargeting {
     this.evaluationEngine = new EvaluationEngine();
   }
 
-<<<<<<< HEAD
   evaluateTargeting({ event, sessionId, userProperties, deviceId, flag }: TargetingParameters) {
-=======
-  evaluateTargeting = async ({
-    apiKey,
-    loggerProvider,
-    event,
-    sessionId,
-    userProperties,
-    deviceId,
-    flag,
-  }: TargetingParameters) => {
-    const eventTypes =
-      event && event.time
-        ? await targetingIDBStore.storeEventTypeForSession({
-            loggerProvider: loggerProvider,
-            apiKey: apiKey,
-            sessionId,
-            eventType: event.event_type,
-            eventTime: event.time,
-          })
-        : undefined;
-
-    const eventStrings = eventTypes && new Set(Object.keys(eventTypes));
-
->>>>>>> 7ea29d5c (fix(targeting): keep track of open db instances and ensure deduplication of events)
     const context = {
       session_id: sessionId,
       event,

packages/targeting/test/targeting.test.ts

@@ -1,13 +1,8 @@
 import { Targeting } from '../src/targeting';
-<<<<<<< HEAD
-=======
-import { targetingIDBStore } from '../src/targeting-idb-store';
->>>>>>> 7ea29d5c (fix(targeting): keep track of open db instances and ensure deduplication of events)
 import { flagConfig } from './flag-config-data';
 
 const mockEvent = {
   event_type: 'sign_in',
-  time: 123,
 };
 const mockUserProperties = {};
 
@@ -17,39 +12,7 @@ describe('targeting', () => {
       const targeting = new Targeting();
       const mockEngineEvaluate = jest.fn();
       targeting.evaluationEngine.evaluate = mockEngineEvaluate;
-<<<<<<< HEAD
       targeting.evaluateTargeting({
-=======
-      await targeting.evaluateTargeting({
-        deviceId: '1a2b3c',
-        userProperties: mockUserProperties,
-        flag: flagConfig,
-        sessionId: 123,
-        apiKey: 'static_key',
-        loggerProvider: mockLoggerProvider,
-      });
-      expect(mockEngineEvaluate).toHaveBeenCalledWith(
-        {
-          user: {
-            device_id: '1a2b3c',
-            user_properties: mockUserProperties,
-          },
-          session_id: 123,
-          event_types: undefined,
-        },
-        [flagConfig],
-      );
-    });
-    test('should pass a list of event types to the evaluation engine evaluate', async () => {
-      jest.spyOn(targetingIDBStore, 'storeEventTypeForSession').mockResolvedValueOnce({
-        'Add to Cart': { 123: { event_type: 'Add to Cart' } },
-        Purchase: { 123: { event_type: 'Purchase' } },
-      });
-      const targeting = new Targeting();
-      const mockEngineEvaluate = jest.fn();
-      targeting.evaluationEngine.evaluate = mockEngineEvaluate;
-      await targeting.evaluateTargeting({
->>>>>>> 7ea29d5c (fix(targeting): keep track of open db instances and ensure deduplication of events)
         deviceId: '1a2b3c',
         event: mockEvent,
         userProperties: mockUserProperties,