Skip to content

Conversation

@tmchow
Copy link
Contributor

@tmchow tmchow commented Oct 28, 2025

Summary

Attribution, pageViews, sessions, fileDownloads, and formInteractions now correctly use config.autocapture instead of only checking the deprecated config.defaultTracking property. Falls back to defaultTracking for backwards compatibility when autocapture is undefined.

Fixes #1369

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

  Attribution, pageViews, sessions, fileDownloads, and formInteractions now
  correctly use config.autocapture instead of only checking the deprecated
  config.defaultTracking property. Falls back to defaultTracking for
  backwards
  compatibility when autocapture is undefined.

  Fixes amplitude#1369
@tmchow
Copy link
Contributor Author

tmchow commented Oct 28, 2025

I had issues with a previous PR I submitted #1360 and at that time @Mercy811 suspected it was due to me not having permissions to the credential vault. They said:

It seems that GitHub blocks access to secrets for security reasons (to prevent malicious PRs from stealing secrets) a pull request from a forked repository.

So someone in Amplitude team with correct access needs to create a new PR and cherry pick the commits please 🙏

@Mercy811
Copy link
Contributor

@tmchow it was because the or was made from a forked repo. If you could just clone, it should work

@tmchow
Copy link
Contributor Author

tmchow commented Oct 28, 2025

@tmchow it was because the or was made from a forked repo. If you could just clone, it should work

@Mercy811 I'm running into issue as I'm getting permission errors about being able to push to this repo though....this is why I created a fork. Meaning, I can't even push a branch up to origin.

@tmchow
Copy link
Contributor Author

tmchow commented Oct 29, 2025

@daniel-graham-amplitude are you able to help? I don't think I have the right permissions in this repo, so someone who does needs to open a new PR and cherry pick my commits to shepherd this through.

@daniel-graham-amplitude
Copy link
Collaborator

@tmchow yes definitely! I'll have a look at this either tonight or first thing tomorrow.

@tmchow
Copy link
Contributor Author

tmchow commented Oct 29, 2025

@tmchow yes definitely! I'll have a look at this either tonight or first thing tomorrow.

Thanks @daniel-graham-amplitude !

@daniel-graham-amplitude daniel-graham-amplitude changed the base branch from main to fix-incorrect-references-autotrack October 29, 2025 17:51
@Mercy811
Copy link
Contributor

Hi @tmchow the fallback logic is supported already. I don't think your fix here (fallback to default tracking when autocapture is undefined) will fix the issue (autocapture.attribution doesn't work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribution tracking fails when configured via autocapture.attribution

3 participants