-
Notifications
You must be signed in to change notification settings - Fork 55
fix(autocapture): prioritize autocapture over deprecated defaultTracking #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fix-incorrect-references-autotrack
Are you sure you want to change the base?
fix(autocapture): prioritize autocapture over deprecated defaultTracking #1372
Conversation
Attribution, pageViews, sessions, fileDownloads, and formInteractions now correctly use config.autocapture instead of only checking the deprecated config.defaultTracking property. Falls back to defaultTracking for backwards compatibility when autocapture is undefined. Fixes amplitude#1369
|
I had issues with a previous PR I submitted #1360 and at that time @Mercy811 suspected it was due to me not having permissions to the credential vault. They said:
So someone in Amplitude team with correct access needs to create a new PR and cherry pick the commits please 🙏 |
|
@tmchow it was because the or was made from a forked repo. If you could just clone, it should work |
|
@daniel-graham-amplitude are you able to help? I don't think I have the right permissions in this repo, so someone who does needs to open a new PR and cherry pick my commits to shepherd this through. |
|
@tmchow yes definitely! I'll have a look at this either tonight or first thing tomorrow. |
Thanks @daniel-graham-amplitude ! |
Summary
Attribution, pageViews, sessions, fileDownloads, and formInteractions now correctly use
config.autocaptureinstead of only checking the deprecatedconfig.defaultTrackingproperty. Falls back todefaultTrackingfor backwards compatibility whenautocaptureis undefined.Fixes #1369
Checklist