-
Notifications
You must be signed in to change notification settings - Fork 504
Some examples fail validation #320
Comments
Hi, amp-fix-flying-carpet is experimental, see doc amp-side-bar should work, but probably the problem is that we are using that twice in the page (for the left menu and the example itself). Please create an issue just for this. Hope it helps. |
The amp-sidebar sample is tricky to get to validate. There are two problems:
|
Would it be possible to use an amp-iframe for the script tag (experimental mode)? |
We can't use an iframe for triggering experimental mode -> experimental flag is stored via cookie which needs to be set for the document host. Fixing samples with amp-sidebar needs to be handled during the example compilation step. |
https://ampbyexample.com/components/amp-form - https://validator.ampproject.org/#url=https%3A%2F%2Fampbyexample.com%2Fcomponents%2Famp-form
https://ampbyexample.com/components/amp-fx-flying-carpet - https://validator.ampproject.org/#url=https%3A%2F%2Fampbyexample.com%2Fcomponents%2Famp-fx-flying-carpet
https://ampbyexample.com/components/amp-live-list - https://validator.ampproject.org/#url=https%3A%2F%2Fampbyexample.com%2Fcomponents%2Famp-fx-flying-carpet
https://ampbyexample.com/components/amp-sidebar - https://validator.ampproject.org/#url=https%3A%2F%2Fampbyexample.com%2Fcomponents%2Famp-sidebar
https://ampbyexample.com/samples_templates/housing/preview/ - https://validator.ampproject.org/#url=https%3A%2F%2Fampbyexample.com%2Fsamples_templates%2Fhousing%2Fpreview%2F
The text was updated successfully, but these errors were encountered: