Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Some examples fail validation #320

Closed
dknecht opened this issue Aug 8, 2016 · 4 comments
Closed

Some examples fail validation #320

dknecht opened this issue Aug 8, 2016 · 4 comments

Comments

@kul3r4
Copy link
Collaborator

kul3r4 commented Aug 8, 2016

Hi,
when samples contain experimental component, it's normal that they don't validate.
amp-form is experimental, so all the examples containing it will fail the validation, such us amp-form and housing.

amp-fix-flying-carpet is experimental, see doc
amp-live-list is experimental, see doc

amp-side-bar should work, but probably the problem is that we are using that twice in the page (for the left menu and the example itself). Please create an issue just for this.

Hope it helps.

@sebastianbenz
Copy link
Collaborator

The amp-sidebar sample is tricky to get to validate. There are two problems:

  1. amp-sidebar needs to be the first element after the body tag (see Make amp-sidebar sample validate #167)
  2. only one sidebar is allowed per page and we have two together with the ABE navigation menu.

@emestud
Copy link

emestud commented Aug 24, 2016

Would it be possible to use an amp-iframe for the script tag (experimental mode)?
This would also allow to have the amp-sidebar as a child of for example in this page: https://ampbyexample.com/samples_templates/product/preview/

@sebastianbenz
Copy link
Collaborator

We can't use an iframe for triggering experimental mode -> experimental flag is stored via cookie which needs to be set for the document host.

Fixing samples with amp-sidebar needs to be handled during the example compilation step.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants