-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AMP settings to include additional options #5578
Comments
See also #5386. |
@jwold IMO, the headings under the Other section for “Redirects” and “Dev Tools” are too similarly-sized to the toggles they are for. Maybe the headings are redundant? |
Per the comment from Weston on #5578 (comment), I'm suggesting a change to the new "Other" panel. The goal is that the design should now look like this: https://d.pr/i/CPtRce. Feedback is welcome, haven't submitted a PR in a while!
@westonruter that's a good point. That heading level has always been a bit weird. I just submitted an attempted fix. Feel free to remove it if my code was incorrect; figured I'd try! 😀 Screenshot of what I'm trying to do: https://d.pr/i/CPtRce |
Per the comment from Weston on #5578 (comment), I'm suggesting a change to the new "Other" panel. The goal is that the design should now look like this: https://d.pr/i/CPtRce. Feedback is welcome, haven't submitted a PR in a while!
Per the comment from Weston on #5578 (comment), I'm suggesting a change to the new "Other" panel. The goal is that the design should now look like this: https://d.pr/i/CPtRce. Feedback is welcome, haven't submitted a PR in a while!
QA passed ✅ Add new section in AMP Settings under Advanced Settings to "redirect mobile visitors to AMP". Turn on by default.The "redirect mobile visitors to AMP" toggle is found under the "Other" section when site is in "Transitional" or "Reader" mode: I can also see that ✅ Remove "redirect mobile visitors to AMP" toggle from onboardingAll good, I did not found this option in onboarding wizzard. ✅ Add new "dev tools" toggle in advanced settings. Make note that it's user role specific (not site wide)All good, "Enable developer tools" toggle found under "Other" section: |
Feature description
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: