Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMP settings to include additional options #5578

Closed
jwold opened this issue Nov 5, 2020 · 5 comments · Fixed by #6501
Closed

Update AMP settings to include additional options #5578

jwold opened this issue Nov 5, 2020 · 5 comments · Fixed by #6501
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one Feedback UX WS:UX Work stream for UX/Front-end
Milestone

Comments

@jwold
Copy link
Collaborator

jwold commented Nov 5, 2020

Feature description

  • Remove "redirect mobile visitors to AMP" toggle from onboarding
  • Add new section in AMP Settings under Advanced Settings to "redirect mobile visitors to AMP". Turn on by default.
  • Add new "dev tools" toggle in advanced settings. Make note that it's user role specific (not site wide)

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter
Copy link
Member

See also #5386.

@jwold
Copy link
Collaborator Author

jwold commented Nov 5, 2020

Screen Shot 2020-11-05 at 9 17 47 AM

@jwold jwold added Enhancement New feature or improvement of an existing one Feedback UX WS:UX Work stream for UX/Front-end labels Nov 5, 2020
@westonruter
Copy link
Member

@jwold IMO, the headings under the Other section for “Redirects” and “Dev Tools” are too similarly-sized to the toggles they are for. Maybe the headings are redundant?

jwold added a commit that referenced this issue Jul 30, 2021
Per the comment from Weston on #5578 (comment), I'm suggesting a change to the new "Other" panel. The goal is that the design should now look like this: https://d.pr/i/CPtRce. Feedback is welcome, haven't submitted a PR in a while!
@jwold
Copy link
Collaborator Author

jwold commented Jul 30, 2021

@westonruter that's a good point. That heading level has always been a bit weird. I just submitted an attempted fix. Feel free to remove it if my code was incorrect; figured I'd try! 😀

Screenshot of what I'm trying to do: https://d.pr/i/CPtRce

delawski pushed a commit that referenced this issue Aug 16, 2021
Per the comment from Weston on #5578 (comment), I'm suggesting a change to the new "Other" panel. The goal is that the design should now look like this: https://d.pr/i/CPtRce. Feedback is welcome, haven't submitted a PR in a while!
@delawski delawski modified the milestones: v2.1.4, v2.2 Aug 16, 2021
delawski pushed a commit that referenced this issue Sep 3, 2021
Per the comment from Weston on #5578 (comment), I'm suggesting a change to the new "Other" panel. The goal is that the design should now look like this: https://d.pr/i/CPtRce. Feedback is welcome, haven't submitted a PR in a while!
@bartoszgadomski
Copy link
Contributor

bartoszgadomski commented Dec 8, 2021

QA passed

✅   Add new section in AMP Settings under Advanced Settings to "redirect mobile visitors to AMP". Turn on by default.

The "redirect mobile visitors to AMP" toggle is found under the "Other" section when site is in "Transitional" or "Reader" mode:

Screenshot 2021-12-8 at 17 35 33

I can also see that mobile_redirect option is set to true by default.

Screenshot 2021-12-8 at 16 55 44

✅   Remove "redirect mobile visitors to AMP" toggle from onboarding

All good, I did not found this option in onboarding wizzard.

✅   Add new "dev tools" toggle in advanced settings. Make note that it's user role specific (not site wide)

All good, "Enable developer tools" toggle found under "Other" section:

Screenshot 2021-12-8 at 16 55 59

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one Feedback UX WS:UX Work stream for UX/Front-end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants