UTP C++ code syntax error? (first time use)

[splace]

Running tool: run +tags

/* run: tags="" Fri 17 Jan 14:28:01 GMT 2025 go version go1.24rc1 linux/amd64
# github.com/anacrolix/go-libutp
In file included from ./utp.h:35,
                 from /var/home/simon/go/pkg/mod/github.com/anacrolix/[email protected]/callbacks.go:4:
./utp_types.h:120:15: error: two or more data types in declaration specifiers
  120 | typedef uint8 bool;
      |               ^~~~

Stopped.

Exited: 15

[anacrolix]

Interesting, it's likely an upstream problem. What C++ compiler and set up are you using?

[splace]

didn't include compiler since seems to be a syntax error, ie any/all compilers?

gcc version 15.0.1 20250114 (Red Hat 15.0.1-0) (GCC)

maybe upstream is doing something narrow that doesn't catch this?

[anacrolix]

For context, the wrapped library (upstream), is a clunky old half C/half C++ library that gets very little updates. However it is very heavily used and very stable.

I'm happy to accept a patch here for it, GCC has probably changed something, without digging in it looks like it's complaining about the fact bool already exists (in C++) and then has a typedef. It might also come from Go, either way it's new and just a backwards compatibility problem.

[splace]

yes, i did wonder if it was some leftover/boilerplate not actually being used. i didn't find any (from a very quick scan)

[anacrolix]

I would guess a recent enough C compiler would include a bool typedef of its own. I suspect the fix will be very simple to add an extra #if guard of some kind to utp_types.h. I took a quick look, my GCC is symlinked to clang 16 and I don't get the issue. I'm not on Linux however.

[anacrolix]

I see GCC 15 was just released 2 weeks ago. I have GCC 14, I'll wait for 15 to be available on Homebrew. GCC 14 did not trigger the error you got for me.