Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure due to PolyHook 2 dependency #80

Open
ambiennt opened this issue Dec 1, 2023 · 1 comment
Open

Compilation failure due to PolyHook 2 dependency #80

ambiennt opened this issue Dec 1, 2023 · 1 comment

Comments

@ambiennt
Copy link

ambiennt commented Dec 1, 2023

Changes to the PolyHook 2 dependency seem to have caused this project to not compile. I believe this commit to PolyHook 2 caused the problem, as it removed PLH::CapstoneDisassembler and its respective header.

image
image


As a temporary workaround, I attempted to use old versions of PolyHook with vcpkg. vcpkg does permit installing specific package versions (such as the most recent one of PolyHook before the above commit) in manifest mode. However, I've been unsuccessful in configuring that after trying for some time:

{
  "name": "dtp",
  "version-string": "0.0.1",
  "dependencies": [
    "polyhook2"
  ],
  "builtin-baseline": "16ee2ecb31788c336ace8bb14c21801efb6836e4",
  "overrides": [
    { 
        "name": "polyhook2", 
        "version": "2023-02-24"
    }
  ]
}

vcpkg install --triplet x86-windows-static (in manifest mode)
image

Versions 2023-05-16 and later of PolyHook 2 do compile as a package. But they include the problematic changes as mentioned above, so this doesn't really fix anything.

@GuardianN06
Copy link

I fixed the issue on a pull request, read the details and have fun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants