Put depenencies on a Map<String, List<Dependency>> instead of List

This will save a filter per module, changing the required time from
O((number of modules)*(number of dependencies)) to O(number of
dependencies). In the case of large projects this could save
some seconds. For example, creating a project with 1000 modules and a
full topology takes ~193 seconds using a List, while using a Map takes
~189 seconds.

Author: srmurguia

src/main/kotlin/com/google/androidstudiopoet/ModuleBlueprintFactory.kt

@@ -7,9 +7,7 @@ import com.google.androidstudiopoet.models.ModuleBlueprint
 
 object ModuleBlueprintFactory {
     fun create(index: Int, config: ConfigPOJO, projectRoot: String): ModuleBlueprint {
-        val dependencies = config.resolvedDependencies
-                .filter { it.from == index}
-                .map { it.to }
+        val dependencies = config.resolvedDependencies[index.toString()]?.map { it.to } ?: listOf()
 
         val dependenciesNames = dependencies.map { getModuleNameByIndex(it) }
         val methodsToCallWithinModule = dependencies.map { getMethodToCallForDependency(it, config, projectRoot) }

src/main/kotlin/com/google/androidstudiopoet/models/ConfigPOJO.kt

@@ -16,6 +16,8 @@ package com.google.androidstudiopoet.models
 
 import com.google.gson.Gson
 import java.security.InvalidParameterException
+import java.util.function.BiFunction
+import kotlin.system.measureTimeMillis
 
 class ConfigPOJO {
 
@@ -82,26 +84,46 @@ class ConfigPOJO {
     val useKotlin: Boolean
         get() = kotlinPackageCount!!.toInt() > 0
 
-    val resolvedDependencies: List<Dependency> by lazy {
-            val allDependencies : MutableSet<Dependency> = mutableSetOf()
-
-            // Add dependencies generated by topologies
-            val givenTopologies = topologies
-            if (givenTopologies != null) {
-                for (parameters in givenTopologies) {
-                    val type = parameters.get("type") ?: throw InvalidParameterException("No type specified in topology $parameters")
-                    val topology : Topologies = Topologies.valueOf(type.toUpperCase())
-                    allDependencies.addAll(topology.generateDependencies(parameters, this))
-                }
-            }
+    val resolvedDependencies: Map<String, List<Dependency>> by lazy {
+
+        val result : MutableMap<String, List<Dependency>> = mutableMapOf()
 
-            // Add explicit dependencies
-            val explicitDependencies = dependencies
-            if (explicitDependencies != null) {
-                allDependencies.addAll(explicitDependencies)
+        val allDependencies: MutableMap<String, MutableList<Dependency>> = mutableMapOf()
+        // Add dependencies generated by topologies
+        val givenTopologies = topologies
+        if (givenTopologies != null) {
+            for (parameters in givenTopologies) {
+                val type = parameters.get("type") ?: throw InvalidParameterException("No type specified in topology $parameters")
+                val topology: Topologies = Topologies.valueOf(type.toUpperCase())
+                val currentDependencies = topology.generateDependencies(parameters, this)
+                addDependencies(allDependencies, currentDependencies)
             }
+        }
+
+        // Add explicit dependencies
+        val explicitDependencies = dependencies
+        if (explicitDependencies != null) {
+            addDependencies(allDependencies, explicitDependencies)
+        }
+
+        // Remove duplicates
+        for (dependency in allDependencies) {
+            result.put(dependency.key, dependency.value.distinct())
+        }
+
+        result
+    }
 
-            allDependencies.toList()
+    private fun addDependencies(to: MutableMap<String, MutableList<Dependency>>, from: List<Dependency>) {
+        for (dependency in from) {
+            val key = dependency.from.toString()
+            if ((!to.containsKey(key)) || to[key] == null) {
+                to[key] = mutableListOf(dependency)
+            }
+            else {
+                to[key]?.add(dependency)
+            }
         }
+    }
 }