Allow pending() in tests

[juliemr]

In the current Jasmine version, there's no way to mark a spec as pending if it's already running asynchronously, which is how jasminewd always runs specs (inside their own controlFlow#execute block). Filed a Jasmine feature request at jasmine/jasmine#937 - but I'm aware that this is probably a strange use case for the pending feature.

[ArturKwiatkowski]

👍

This is very nice feature when anyone does E2E conditional testing or even if you just want to skip some tests due to some other factors.

[kyleect]

Definitely a need for this. We have E2E tests that conditionally run in different parts of the year as features are turned on and off to meet business need. Right now xit().pend('reason') is the only way to do this which is fine but has its own problems.

1. The jasmine.d.ts file on DefinitelyTyped is horribly out of date and will not compile unless you patch the definition file. I'm working on a pull request to fix that.
2. The pending reason is at the bottom of the it block. Again you could define the reason text as a variable at the top but its addition overhead.

[mwsessom]

+1

[formarfr]

+1

[order12a]

+1

[sgibson21]

I extended the jasmine-spec-reporter (https://www.npmjs.com/package/jasmine-spec-reporter)

var SpecReporter = require('jasmine-spec-reporter');
var PendingSpecReporter = SpecReporter;

PendingSpecReporter.prototype.specDone = function (spec) {
  this.metrics.stopSpec(spec);
  var pending = false;
  for(var i = 0; i < spec.failedExpectations.length; i++) {
    if ( spec.failedExpectations[i].message.toLowerCase().indexOf('pending') >= 0) pending = true;
  }
  if (spec.status === 'pending' || pending) {
    this.metrics.pendingSpecs++;
    this.display.pending(spec);
  } else if (spec.status === 'passed') {
    this.metrics.successfulSpecs++;
    this.display.successful(spec);
  } else if (spec.status === 'failed') {
    this.metrics.failedSpecs++;
    this.display.failed(spec);
  }
};

module.exports = PendingSpecReporter;

Specs marked as pending are displayed as pending in the report if any failedExpectation messages contain the word pending.

[heathkit]

Being able to disable the control flow should also fix this.

[larsgu]

Why is it that this still hasn't been acted on?
It seems like an obvious and simple use case, the ability to mark a spec as pending and have it reported as pending, with a reason given by the user.
As it is now, the .pend solution mentioned by @kyleect no longer works, and using pending("reason") inside the spec reports it as failed instead of pending.
Does anyone know of a simple workaround (for Protractor with typescript)?

[maodean001]

any updates on this issue or just been ignored?

[Kitsula]

Short workaround:
(environment.postDeployment ? xit : it)('should something', () => { expect(true).toBeTruthy(); });

[maodean001]

Thanks Kitsula for your response. I did a similar way to have a logic check switching to xit if it meant to be ignored pro grammatically.

Instead of duplicating (environment.postDeployment ? xit : it) everywhere, I override it and describe global method. If you have test name including special tags e.g. "#dev #test #uat", then I will check if I ignore the tests intentionally and also remove the tags from the test name.

Anyway, it is almost same logic as yours. it works good for me.

Thanks,