Removing the Dimensions instance property (v6) (#1612)

Related to #1610

Author: lipchev

CodeGen/Generators/UnitsNetGen/IQuantityTestClassGenerator.cs

@@ -61,16 +61,6 @@ public void QuantityInfo_IsSameAsStaticInfoProperty()
             Assertion({quantity.Name}.Info, {quantity.Name}.Zero);");
             Writer.WL($@"
         }}
-
-        [Fact]
-        public void Dimensions_IsSameAsStaticBaseDimensions()
-        {{
-            void Assertion(BaseDimensions expected, IQuantity quantity) => Assert.Equal(expected, quantity.Dimensions);
-");
-            foreach (var quantity in _quantities) Writer.WL($@"
-            Assertion({quantity.Name}.BaseDimensions, {quantity.Name}.Zero);");
-            Writer.WL($@"
-        }}
     }}
 }}");
 

CodeGen/Generators/UnitsNetGen/QuantityGenerator.cs

@@ -374,11 +374,6 @@ private void GenerateProperties()
         /// <inheritdoc />
         public QuantityInfo<{_quantity.Name}, {_unitEnumName}> QuantityInfo => Info;
 
-        /// <summary>
-        ///     The <see cref=""BaseDimensions"" /> of this quantity.
-        /// </summary>
-        public BaseDimensions Dimensions => {_quantity.Name}.BaseDimensions;
-
         #region Explicit implementations
 
         [DebuggerBrowsable(DebuggerBrowsableState.Never)]

UnitsNet.Tests/BaseDimensionsTests.cs

@@ -421,33 +421,13 @@ public void CheckBaseDimensionDivisionWithSpeedEqualsDistanceDividedByTimeOnStat
             Assert.True(calculatedDimensions == Speed.BaseDimensions);
         }
 
-        [Fact]
-        public void CheckBaseDimensionDivisionWithSpeedEqualsDistanceDividedByTimeOnInstanceProperty()
-        {
-            var length = Length.FromKilometers(100);
-            var duration = Duration.FromHours(1);
-
-            BaseDimensions calculatedDimensions = length.Dimensions.Divide(duration.Dimensions);
-            Assert.True(calculatedDimensions == Speed.BaseDimensions);
-        }
-
         [Fact]
         public void CheckBaseDimensionMultiplicationWithForceEqualsMassTimesAccelerationOnStaticProperty()
         {
             BaseDimensions calculatedDimensions = Mass.BaseDimensions.Multiply(Acceleration.BaseDimensions);
             Assert.True(calculatedDimensions == Force.BaseDimensions);
         }
 
-        [Fact]
-        public void CheckBaseDimensionMultiplicationWithForceEqualsMassTimesAccelerationOnInstanceProperty()
-        {
-            var mass = Mass.FromPounds(205);
-            var acceleration = Acceleration.FromMetersPerSecondSquared(9.8);
-
-            BaseDimensions calculatedDimensions = mass.Dimensions.Multiply(acceleration.Dimensions);
-            Assert.True(calculatedDimensions == Force.BaseDimensions);
-        }
-
         [Fact]
         public void EqualityWorksAsExpectedWithOperatorOverloads()
         {
@@ -703,33 +683,13 @@ public void CheckBaseDimensionDivisionWithSpeedEqualsDistanceDividedByTimeOnStat
             Assert.True(calculatedDimensions == Speed.BaseDimensions);
         }
 
-        [Fact]
-        public void CheckBaseDimensionDivisionWithSpeedEqualsDistanceDividedByTimeOnInstancePropertyWithOperatorOverloads()
-        {
-            var length = Length.FromKilometers(100);
-            var duration = Duration.FromHours(1);
-
-            BaseDimensions calculatedDimensions = length.Dimensions / duration.Dimensions;
-            Assert.True(calculatedDimensions == Speed.BaseDimensions);
-        }
-
         [Fact]
         public void CheckBaseDimensionMultiplicationWithForceEqualsMassTimesAccelerationOnStaticPropertyWithOperatorOverloads()
         {
             BaseDimensions calculatedDimensions = Mass.BaseDimensions * Acceleration.BaseDimensions;
             Assert.True(calculatedDimensions == Force.BaseDimensions);
         }
 
-        [Fact]
-        public void CheckBaseDimensionMultiplicationWithForceEqualsMassTimesAccelerationOnInstancePropertyWithOperatorOverloads()
-        {
-            var mass = Mass.FromPounds(205);
-            var acceleration = Acceleration.FromMetersPerSecondSquared(9.8);
-
-            BaseDimensions calculatedDimensions = mass.Dimensions * acceleration.Dimensions;
-            Assert.True(calculatedDimensions == Force.BaseDimensions);
-        }
-
         [Fact]
         public void CheckToStringUsingMolarEntropy()
         {

UnitsNet.Tests/CustomQuantities/HowMuch.cs

@@ -58,10 +58,7 @@ QuantityInfo IQuantity.QuantityInfo
         {
             get => Info;
         }
-
-        public BaseDimensions Dimensions => Info.BaseDimensions;
-
-
+        
         UnitKey IQuantity.UnitKey
         {
             get => UnitKey.ForUnit(Unit);