Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - "Reviewing" & Deck import do not handle SchedV1 correctly #17838

Open
4 tasks done
david-allison opened this issue Jan 17, 2025 · 13 comments · May be fixed by #17857
Open
4 tasks done

Settings - "Reviewing" & Deck import do not handle SchedV1 correctly #17838

david-allison opened this issue Jan 17, 2025 · 13 comments · May be fixed by #17857
Assignees
Labels
Help Wanted Requesting Pull Requests from volunteers Priority-High

Comments

@david-allison
Copy link
Member

david-allison commented Jan 17, 2025

Checked for duplicates?

  • This issue is not a duplicate

Does it also happen in the desktop version?

  • This bug does not occur in the latest version of Anki Desktop

What are the steps to reproduce this bug?

  • replace your collection with this colpkg: .zip
  • Settings - Reviewing
  • 3 dialogs appear, all looking identical, so it looks like dismissing doesn't work
Image

Expected behaviour

A dialog like this:

Image

Debug info

AnkiDroid Version = 2.21alpha7-debug (e8a464e59ac387c7e154d0fb16a0222e0f48944d)
Backend Version = 0.1.48-anki24.11 (24.11 c47638ca36f99dd4f3b81ae82d964aec66e392e0)
Android Version = 9 (SDK 28)
ProductFlavor = amazon
Device Info = unknown | Android | generic_arm64 | sdk_gphone_arm64 | Android SDK built for arm64 | ranchu
Webview User Agent = Mozilla/5.0 (Linux; Android 9; Android SDK built for arm64 Build/PSR1.210301.009.B1; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/94.0.4606.71 Mobile Safari/537.36
ACRA UUID = 9ee8f6b3-3baf-4059-9681-be5eaca8a300
FSRS = 1.4.3 (Enabled: false)
Crash Reports Enabled = false

(Optional) Anything else you want to share?

No response

Research

  • I have checked the manual and the FAQ and could not find a solution to my issue
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
@david-allison david-allison changed the title Settings - "Reviewing" does not handle SchedV2 correctly Settings - "Reviewing" & Deck import do not handle SchedV2 correctly Jan 17, 2025
@david-allison
Copy link
Member Author

david-allison commented Jan 17, 2025

I've seen this one a few times in reviews for 2.19. @mikehardy would you support a backport for a [probably simple] fix, since we've done a huge upgrade for some users with:

@david-allison david-allison added the Help Wanted Requesting Pull Requests from volunteers label Jan 17, 2025
@snowtimeglass
Copy link
Contributor

snowtimeglass commented Jan 17, 2025

@david-allison

"Reviewing" & Deck import do not handle SchedV2 correctly

I may be misreading what you mean, but at the moment the title looks misleading or incorrect to me. If I understand correctly, the error occurs just when users' collections are using V1 scheduler, not V2 scheduler. Do you have a different view on this point?

@david-allison david-allison changed the title Settings - "Reviewing" & Deck import do not handle SchedV2 correctly Settings - "Reviewing" & Deck import do not handle SchedV1 correctly Jan 17, 2025
@david-allison
Copy link
Member Author

david-allison commented Jan 17, 2025

@snowtimeglass no, fair point. Title updated

EDIT: Just confirmed. It's SchedV1

@david-allison david-allison changed the title Settings - "Reviewing" & Deck import do not handle SchedV1 correctly Settings - "Reviewing" & Deck import do not handle outdated scheduler correctly Jan 17, 2025
@david-allison david-allison changed the title Settings - "Reviewing" & Deck import do not handle outdated scheduler correctly Settings - "Reviewing" & Deck import do not handle SchedV1 correctly Jan 17, 2025
@mikehardy
Copy link
Member

I would definitely take a backport if it was reasonable at all, as a set of commit picks

@mikehardy
Copy link
Member

For what it's worth, user reports that you can create a new deck, then press on the deck, and that will update things? I'm not 100% clear on that, and I have not tested it personally - just saying that there is a report of success getting a v1 collection back to usability on 2.19...

Obviously a real fix here would be preferable 😆

@david-allison
Copy link
Member Author

This issue is specifically for errors on the 'Reviewing' and 'Deck Import', which do not offer a path to upgrade.

If the user has a reviewable deck, then they can click on that and the upgrade to V3 is offered.

If the user does not have decks, the UX of upgrading would be unlikely to lead to success

@snowtimeglass
Copy link
Contributor

It may be desirable for UX to show the message without waiting for user tapping a deck, as in 1 below.

  1. Just after starting the desktop version:
    Image

  2. In case of ignoring the message above and then select a deck
    Image

@snowtimeglass
Copy link
Contributor

For reference of AnkiDroid (2.21alpha7) behavior:

Record_2025-01-18-14-44-22_c428a0327e1e5e78cdd71c6b04816edf.mp4

@oyeraghib
Copy link
Contributor

Hi, I want to help with this issue. Please assign if it is not taken.

@oyeraghib
Copy link
Contributor

On clicking Stats in Anki this error comes up. Seems like the similar message upon pressing "Reviewing" in Ankidroid. It mentions the option "Learn More" but only gives "OK" as the option.

@david-allison
Copy link
Member Author

Worth dropping a bug upstream for that one

@snowtimeglass
Copy link
Contributor

snowtimeglass commented Jan 20, 2025

On clicking Stats in Anki this error comes up. Seems like the similar message upon pressing "Reviewing" in Ankidroid. It mentions the option "Learn More" but only gives "OK" as the option.

Worth dropping a bug upstream for that one

In the desktop version, the error message can be interpreted that "Please select Learn More, which is already shown in the main screen, before proceeding". This flow may have room for improvement of UX, but not so much as a bug, in my opinion.

Image

Image

@oyeraghib
Copy link
Contributor

On clicking Stats in Anki this error comes up. Seems like the similar message upon pressing "Reviewing" in Ankidroid. It mentions the option "Learn More" but only gives "OK" as the option.

Worth dropping a bug upstream for that one

In the desktop version, the error message can be interpreted that "Please select Learn More, which is already shown in the main screen, before proceeding". This flow may have room for improvement of UX, but not so much as a bug, in my opinion.

Image

Image

I think the same dialog which is prompted on the main screen should be prompted here instead of showing it as an error from backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Requesting Pull Requests from volunteers Priority-High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants