Don't allow empty name in flag #17856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayatriii0803
force-pushed
the
flag
branch
2 times, most recently
from
440f0e0 to
e691ed8
Compare
criticalAY
reviewed
Jan 23, 2025
| @@ -92,6 +93,10 @@ class FlagAdapter( | |||
|
|
|||
| holder.saveButton.setOnClickListener { | |||
| val updatedTextName = holder.flagNameEdit.text.toString() | |||
| if (updatedTextName.isEmpty()) { | |||
| showThemedToast(holder.itemView.context, R.string.empty_flag_message, true) | |||
There was a problem hiding this comment.
No toasts please, the ideal approach would be to utilise the TextInputLayout and show error text or do it the Anki way i.e. if user tries to save empty flag name then set it back to the default name which was used last
lukstbit
added
the
Needs Author Reply
lukstbit
requested changes
Jan 23, 2025
lukstbit
approved these changes
Jan 31, 2025
lukstbit
added
Needs Second Approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes the issue where a flag could be renamed to an empty value in the Card Browser. Now, empty flag names are not allowed.
Fixes
Approach
If user tries to save empty flag name then set it back to the default name which was used.
How Has This Been Tested?
Physical device (OPPO F21 Pro 5G)
flag.mp4
Checklist
Please, go through these checks before submitting the PR.