Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored de-duplicate .csv/.tsv values both in IntentHandler and in ImportFileSelectionFragment. #17887

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

argon2r
Copy link

@argon2r argon2r commented Jan 27, 2025

Purpose / Description

Refactored .csv/.tsv values both in IntentHandler and in ImportFileSelectionFragment.

Fixes

Approach

Refactored the code to remove duplication by centralizing the .csv and .tsv MIME type definitions into a shared utility class (MimeTypeUtils).

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link

welcome bot commented Jan 27, 2025

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

@Scapesfear
Copy link
Contributor

For linking the issue correctly use - Fixes #17875.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: de-duplicate .csv/.tsv values both in IntentHandler and in ImportFileSelectionFragment
2 participants