-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border between column header and first row #17894
Comments
Taking it up |
Doesn't this feel incomplete? Adding a border to the left side and around the column headers would give it a more polished and complete look IMO. |
Maybe, but I don't remember seeing any app having borders on the left and right sides. So, I think that we should remove the right border. |
Seems legit, but then the bottom one should be there at least. |
Hey @Siddheshjondhale, are you still working on it? While looking into the issue #17896, I solved it. Can I go ahead and make the PR for it? |
Actually, the issue you mentioned (#17896) seems to be the same as this one, so there’s redundancy in the issue listing. I’m already working on it and have asked for suggestions on the anki-design Discord. Could you please look into other issues instead? Thanks! |
@Siddheshjondhale ummm.. this LGTM. If this issue remains unresolved on your end or hasn't received sufficient attention yet, it might be more productive to focus efforts elsewhere rather than duplicating work that has already been completed. |
Yeah that makes sense too. I'll focus on other issues rather than working on this one since it's already been resolved. And yeah, @argon2r feel free to go ahead and make a PR for it. |
IMO, there should be a border between the column headers and the first row.
Also, I don't think we need the border on the right. Probably, we also don't need a border at the bottom. This one might be controversial, though. (Spoiler: the bottom border was not there in 2.20)
The text was updated successfully, but these errors were encountered: