Skip to content

Add iterators in addition to GitDiff::Diff#files and GitDiff::File#hunks #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dadooda opened this issue Sep 28, 2015 · 1 comment

Comments

@dadooda
Copy link
Contributor

dadooda commented Sep 28, 2015

Hi Andrew,

At the moment methods like GitDiff::Diff#files and GitDiff::File#hunks return pre-filled Arrays, which isn't that optimal if you deal with big input data. I think adding iterators like #each_file, #each_hunk etc. would make it a lot more optimal performance-wise and memory-wise.

Cheers.

Alex

@anolson
Copy link
Owner

anolson commented Sep 29, 2015

Hey Alex,

This seems like a pretty reasonable idea. I should be able to get something together fairly soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants