Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin option choices: both 'bool' and 'boolean' are valid types for plugins, and should be treated the same #5415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felixfontein
Copy link
Contributor

This bug was reported in ansible-collections/community.general#9573 (comment).

Example: https://galaxy.ansible.com/ui/repo/published/community/general/content/inventory/iocage/#parameters option "leading_separator", which is a boolean with type boolean with default false. "trailing_separator", on the other hand, is a boolean of type bool with default true.

…treated the same.

No-Issue
Signed-off-by: Felix Fontein <[email protected]>
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

There's one more bool mention in documentedType, but that one already behaves the same for bool and boolean. So looks like you found all of them :)

@felixfontein
Copy link
Contributor Author

There's one more bool mention in documentedType, but that one already behaves the same for bool and boolean.

Yeah, that's why I didn't adjust it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants