-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zero width of spacer columns indenting suboptions and sub-return values #5417
Conversation
…values. Signed-off-by: Felix Fontein <[email protected]>
586ab4f
to
0c8b264
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felixfontein
@felixfontein I .. have no idea :) Probably not. Buut ... looking good, restarted tests (those look like just ordinary sporadic failures, nothing caused by this PR) aand approved :) |
@felixfontein Approved all of them :) (One note, all of these issues will likely be present in the aap ui repo as well, might want to fix it there too :)) |
Hmm, do you have any idea who is responsible for Galaxy / this repo now?
Is there a separate repo for AAP UI that basically does similar things than this one? I assumed that AAP basically uses this repo as well as upstream... (But then I never used AAP, so 🤷) |
None, my apologies. I can try asking around. That would have been true up to and including 2.4, but the later versions' UI is an unrelated effort. You can see some of it in https://github.com/ansible/ansible-ui/, after which development moved to a private repo. Which likely limits your ability to fix anything there :) |
@felixfontein thanks for this PR! We're asking around for who can review and merge so bear with us for a bit :-) |
The CSS from table.css (coming from some dependency, I guess) overrides
width
with0
due to the column being:empty
. This makes the indent almost disappear (you can still see it by noticing that the left border line is a tiny bit thicker).For example, check out the return values here:
Before:

After:
