Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero width of spacer columns indenting suboptions and sub-return values #5417

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

felixfontein
Copy link
Contributor

The CSS from table.css (coming from some dependency, I guess) overrides width with 0 due to the column being :empty. This makes the indent almost disappear (you can still see it by noticing that the left border line is a tiny bit thicker).

For example, check out the return values here:

Before:
image

After:
image

Copy link

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixfontein

@felixfontein
Copy link
Contributor Author

@himdel are you still the right person to ping? I have this and two other bugfix PRs (#5416, #5415) that are waiting for reviews.

@himdel
Copy link
Collaborator

himdel commented Feb 17, 2025

are you still the right person to ping?

@felixfontein I .. have no idea :) Probably not.

Buut ... looking good, restarted tests (those look like just ordinary sporadic failures, nothing caused by this PR) aand approved :)

@himdel
Copy link
Collaborator

himdel commented Feb 17, 2025

@felixfontein Approved all of them :) (One note, all of these issues will likely be present in the aap ui repo as well, might want to fix it there too :))

@felixfontein
Copy link
Contributor Author

@felixfontein I .. have no idea :) Probably not.

Hmm, do you have any idea who is responsible for Galaxy / this repo now?

(One note, all of these issues will likely be present in the aap ui repo as well, might want to fix it there too :))

Is there a separate repo for AAP UI that basically does similar things than this one? I assumed that AAP basically uses this repo as well as upstream...

(But then I never used AAP, so 🤷)

@himdel
Copy link
Collaborator

himdel commented Feb 18, 2025

None, my apologies. I can try asking around.

That would have been true up to and including 2.4, but the later versions' UI is an unrelated effort. You can see some of it in https://github.com/ansible/ansible-ui/, after which development moved to a private repo. Which likely limits your ability to fix anything there :)

@samccann
Copy link

@felixfontein thanks for this PR! We're asking around for who can review and merge so bear with us for a bit :-)

@prat98 prat98 merged commit 5b9f58e into ansible:master Feb 26, 2025
12 of 14 checks passed
@felixfontein felixfontein deleted the table-suboption branch February 26, 2025 19:03
@felixfontein
Copy link
Contributor Author

@samccann thanks!

@prat98 thanks for merging this! Can you also take a look at #5416 and #5415?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants