Can't enable tomcat on Debian 8 (Jessie)

[geekix]

Hello,

I have a problem when deploying Tomcat on Debian 8 (Jessie) with your module. As I am using Debian, your module doesn't deploy systemd service file and relies only on init script.
And I presume that puppet can't enable Tomcat because the init script is missing Default-Start and Default-Stop values. Maybe there is a reason for that?

Here is the error message I get :

Error: Could not enable tomcat8: Error: /Stage[main]/Tomcat::Service::Archive/Service[tomcat8]/enable: change from false to true failed: Could not enable tomcat8:

The init script should be LSB compliant, see : https://wiki.debian.org/LSBInitScripts

Tell me if you need more infos and if you could update init script template.

Thanks

[antoineco]

Thanks for the bug report!

I disabled systemd support on Debian because the official package shipped only with an init script. Looks like it's time for me to revisit it.

Does it work with the "package" installation?

[geekix]

Hello,

I should have mentioned that I'm installing tomcat with the archive and not the package. I will test the package installation tomorrow and give you a feedback.

[antoineco]

I'm not expecting the package to fail since this module doesn't alter the package content, so don't spend too much time testing if you haven't already :)

The LSB compliance error makes sense, last time I tried Debian wasn't so picky but it's an easy fix. Maybe it would make sense to default to using systemd instead of sysvinit from Debian 8 onwards, regardless of what's done in the official package.

[geekix]

I took a minute to test the installation with the package on Debian 8, it works as expected. Here are the default values in the init script deployed by the package :

Default-Start: 2 3 4 5
Default-Stop: 0 1 6

Going full systemd for Debian 8 makes sense, however, it seems that systemd is using init script to start and stop tomcat :

`user@server:~# cat /run/systemd/generator.late/tomcat8.service
# Automatically generated by systemd-sysv-generator

[Unit]
SourcePath=/etc/init.d/tomcat8
Description=LSB: Start Tomcat.
Before=runlevel2.target runlevel3.target runlevel4.target runlevel5.target shutdown.target
After=local-fs.target remote-fs.target network-online.target nss-lookup.target
Wants=network-online.target
Conflicts=shutdown.target

[Service]
Type=forking
Restart=no
TimeoutSec=5min
IgnoreSIGPIPE=no
KillMode=process
GuessMainPID=no
RemainAfterExit=yes
SysVStartPriority=1
ExecStart=/etc/init.d/tomcat8 start
ExecStop=/etc/init.d/tomcat8 stop`